-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@azure/search-documents] Commit Aliases Operations for Search Index Client #20658
Conversation
API changes have been detected in |
createIndex(index: SearchIndex, options?: CreateIndexOptions): Promise<SearchIndex>; | ||
createOrUpdateAlias(alias: SearchIndexerAlias, options?: CreateOrUpdateAliasOptions): Promise<SearchIndexerAlias>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this has changed a few times but at least when I was adding an upsert-like operation to AKV we settled on set
instead of createOrUpdate
or upsert
(so setAlias
in this case).
I was also wondering: why is there both createAlias
and createOrUpdateAlias
- does createAlias
throw if the alias already exists? Do we need both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- In
search-documents
SDK, Yes. We have bothcreate
/createOrUpdate
operations for all entities such as Indexes, SynonymMaps, DataSourceConnections, etc. To be in sync with that and other language SDKs, the same policy is followed here. - Yes. The
create
method will throw an error if the entity exists already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor remarks on the API shape, but overall seems reasonable.
@joheredi can you take a look too?
@@ -1932,6 +1963,9 @@ export interface SearchIndexer { | |||
targetIndexName: string; | |||
} | |||
|
|||
// @public | |||
export type SearchIndexerAlias = SearchAlias; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have both SearchAlias
and SearchIndexerAlias
? Seems like we only need one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, it should be SearchIndexAlias
. I will fix that. But, why do we have both? The reason is I have renamed the SearchAlias to SearchIndexAlias to be in sync with other naming conventions we followed in the SDK.
And both has to be exposed in the index file. Else, API Extractor will complain about a missing export.
getIndex(indexName: string, options?: GetIndexOptions): Promise<SearchIndex>; | ||
getIndexStatistics(indexName: string, options?: GetIndexStatisticsOptions): Promise<SearchIndexStatistics>; | ||
getSearchClient<T>(indexName: string, options?: SearchClientOptions): SearchClient<T>; | ||
getServiceStatistics(options?: GetServiceStatisticsOptions): Promise<SearchServiceStatistics>; | ||
getSynonymMap(synonymMapName: string, options?: GetSynonymMapsOptions): Promise<SynonymMap>; | ||
listAliases(options?: ListAliasesOptions): Promise<Array<SearchIndexerAlias>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're sure we don't want an iterator for these? What are the limits of how many can be returned / exist on an account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified the listAliases
API to return AliasIterator
similar to the the listIndexes
API. Thanks
API changes have been detected in |
/** Defines the If-Match condition. The operation will be performed only if the ETag on the server matches this value. */ | ||
ifMatch?: string; | ||
/** Defines the If-None-Match condition. The operation will be performed only if the ETag on the server does not match this value. */ | ||
ifNoneMatch?: string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like we are not giving our users the option to set this option. Is that expected?
|
||
const result = await this.client.aliases.createOrUpdate(alias.name, alias, { | ||
...updatedOptions, | ||
ifMatch: etag, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the guidelines, my understanding is that the expectation is to set if-none-match
when onlyIfUnchanged
is true or ifMatch
when onlyIfChanged
https://azure.github.io/azure-sdk/typescript_design.html#ts-conditional-requests
/** | ||
* If set to true, Resource will be deleted only if the etag matches. | ||
*/ | ||
onlyIfUnchanged?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should make this
matchCondition?: "onlyIfChanged" | "onlyIfUnchanged";
Merge Microsoft.app 2022 06 01 preview to main (Azure#20787) * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (Azure#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <[email protected]> * Fix definition for customhostnameesult (Azure#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048) * Correct Probe enums (Azure#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (Azure#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc551b3239598157238ed6246085748421b87. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <[email protected]> Co-authored-by: Mike Vu <[email protected]> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <[email protected]> Co-authored-by: tombuildsstuff <[email protected]> * Fix description in all API versions (Azure#19313) * Fix description for ManagedEnvironment.Internal property (Azure#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (Azure#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (Azure#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (Azure#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <[email protected]> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <[email protected]> * Add custom domain configuration for managed environment (Azure#20149) Co-authored-by: Mengjun Qin <[email protected]> * Add additional Dapr options (2022-06-01-preview) (Azure#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (Azure#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <[email protected]> * Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261) * Revert "Add traffic info to revisions api (Azure#19054)" This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b. * Remove traffic labels from revisions * Add property for tcp apps (Azure#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (Azure#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <[email protected]> * Update container app provisioningstate (Azure#20411) * update * update * add property: maxInactiveRevisions (Azure#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (Azure#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <[email protected]> * Fix source control status code in 2022-06-01-preview. (Azure#20429) * Remove 20220501 because we will not support it in server side (Azure#20427) * remove * update * Added support for user defined routing (Azure#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * Some more APIs (Azure#20448) * new APIs to 06-01 * test fix * more fixes * add last active time for revision (Azure#20658) * Add custom domain for connected env (Azure#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (Azure#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Fix 2022-06-01-preview branch merge conflicts (Azure#20773) * Reset * more fixes * More fixes * another conflict fix * Fix old preview version * fix 2022-03-01 * supress lint Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Ruslan Yakushev <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Mike Vu <[email protected]> Co-authored-by: tombuildsstuff <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Mengjun Qin <[email protected]> Co-authored-by: Mengjun Qin <[email protected]> Co-authored-by: Taher Daroly <[email protected]> Co-authored-by: Taher Darolywala <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: p-bouchon <[email protected]> Co-authored-by: p-bouchon <[email protected]> Co-authored-by: njucz <[email protected]> Co-authored-by: JJ <[email protected]> Co-authored-by: Chenjie Shi <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Mahmoud Desokey <[email protected]> Co-authored-by: Xingjian Wang <[email protected]> Co-authored-by: trajkobal <[email protected]>
Rename Post Action and Add Secrets Tags (Azure#20775) * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (Azure#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <[email protected]> * Fix definition for customhostnameesult (Azure#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048) * Correct Probe enums (Azure#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (Azure#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc551b3239598157238ed6246085748421b87. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <[email protected]> Co-authored-by: Mike Vu <[email protected]> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <[email protected]> Co-authored-by: tombuildsstuff <[email protected]> * Fix description in all API versions (Azure#19313) * Fix description for ManagedEnvironment.Internal property (Azure#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (Azure#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (Azure#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (Azure#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <[email protected]> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <[email protected]> * Add custom domain configuration for managed environment (Azure#20149) Co-authored-by: Mengjun Qin <[email protected]> * Add additional Dapr options (2022-06-01-preview) (Azure#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (Azure#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <[email protected]> * Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261) * Revert "Add traffic info to revisions api (Azure#19054)" This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b. * Remove traffic labels from revisions * Add property for tcp apps (Azure#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (Azure#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <[email protected]> * Update container app provisioningstate (Azure#20411) * update * update * add property: maxInactiveRevisions (Azure#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (Azure#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <[email protected]> * Fix source control status code in 2022-06-01-preview. (Azure#20429) * Remove 20220501 because we will not support it in server side (Azure#20427) * remove * update * Added support for user defined routing (Azure#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * Some more APIs (Azure#20448) * new APIs to 06-01 * test fix * more fixes * add last active time for revision (Azure#20658) * Add custom domain for connected env (Azure#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (Azure#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Rename Action * secrets tag * missed fix Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Ruslan Yakushev <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: Mike Vu <[email protected]> Co-authored-by: tombuildsstuff <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Mengjun Qin <[email protected]> Co-authored-by: Mengjun Qin <[email protected]> Co-authored-by: Taher Daroly <[email protected]> Co-authored-by: Taher Darolywala <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: p-bouchon <[email protected]> Co-authored-by: p-bouchon <[email protected]> Co-authored-by: njucz <[email protected]> Co-authored-by: JJ <[email protected]> Co-authored-by: Chenjie Shi <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Mahmoud Desokey <[email protected]> Co-authored-by: trajkobal <[email protected]>
Availableworkloadprofiles - GET endpoint (Azure#20650) * Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01 * Updates readme * Updates API version in new specs and examples * Add app diag to 2022-05-01 (Azure#18678) * Add container apps diagnostics * Fix validation errors * Move Microsoft.App diag APIs to 2022-05-01 * Fix validation errors * Fix validation errors * Fix validation errors 3 * Change operationIds Co-authored-by: Michimune Kohno <[email protected]> * Fix definition for customhostnameesult (Azure#19014) * fix * update * more fix * Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048) * Correct Probe enums (Azure#18839) * fix probe enums * Fix revision mode enum * Fix patch example * Fix the casing of enums in the latest api version * Change the parameter names to unblock Terraform release (Azure#19005) * contianerapps: fixing swagger inconsistencies in 2022-01-01-preview * containerapps: fixing inconsistencies in the 2022-03-01 swagger * containerapps: updating the examples for 2022-01-01-preview * containerapps: updating the examples to account for the updated parameter names * containerapps: fixing linting * fix probe enums * Fix revision mode enum * Fix the policheck error * Revert "containerapps: fixing linting" This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8. * Revert "containerapps: updating the examples for 2022-01-01-preview" This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c. * Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview" This reverts commit 553fc551b3239598157238ed6246085748421b87. * Undo changes to 2022-01-01-preview * Fix one issue * fix remaining inconsistency * fix authConfig and sourceControl names Co-authored-by: tombuildsstuff <[email protected]> Co-authored-by: Mike Vu <[email protected]> * Change param names * Fix examples * Fix CI errors Co-authored-by: Mike Vu <[email protected]> Co-authored-by: tombuildsstuff <[email protected]> * Fix description in all API versions (Azure#19313) * Fix description for ManagedEnvironment.Internal property (Azure#19307) * Fix descriptions in all api versions * Add traffic info to revisions api (Azure#19054) * Add traffic info to a revision api * Add deprecated prop * Prettier fixes * 1pdate based on new proposal * Rename * Change names * minor fix * Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360) * Add httpReadBufferSize to dapr config * remove nullable * Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview * Updates readme * Updates API version in new specs and examples * Add new resources for 2022-06-01-preview (Azure#19494) * update * update * update * fix * update * update * update * update * fix * update * update * Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974) * Enable Dapr AI Connection string for Microsoft.App connected environment * Fix dapr ai connection string * remove read * remove read permission of dapr ai connection string and instrument key for managed environment * fixes for comments * update (Azure#20013) * Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133) * Fix casing for detector properties * Fix descriptions * Fix descriptions and detectorProperties in 2022-06-01-preview * Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044) * Added `secretsStoreComponent` in 2022-06-01 spec Signed-off-by: ItalyPaleAle <[email protected]> * Fixed typos and added example of name/key Signed-off-by: ItalyPaleAle <[email protected]> * Add custom domain configuration for managed environment (Azure#20149) Co-authored-by: Mengjun Qin <[email protected]> * Add additional Dapr options (2022-06-01-preview) (Azure#19886) * Add additional Dapr options * Update examples for 2022-06-01-preview * force ci * force ci * force ci * adding ip-restriction feat (Azure#19841) * adding ip-restriction feat * remove from stable, add to preview * fix lintDiff error * fix modelvalidation error * fix formatting changes * rename names, add note to all allow or all deny * fix spell check error * update name and examples * rename `ipAddress` to `ipAddressRange` * making small change to re-run build pipeline * trigger GitHub actions * resolve comments Co-authored-by: Taher Darolywala <[email protected]> * Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261) * Revert "Add traffic info to revisions api (Azure#19054)" This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b. * Remove traffic labels from revisions * Add property for tcp apps (Azure#20193) * Add property for tcp apps * Add scale * Fix * Fix * Add Init Containers to common definitions (Azure#19855) * add init containers to common definitions * move changes to 06-01 preview * remove repeated container definition * fix allof syntax * fix anonymous container definition * fix lintdiff errors * fix container allof syntax * add more init examples * split baseContainer definition * remove description Co-authored-by: p-bouchon <[email protected]> * Update container app provisioningstate (Azure#20411) * update * update * add property: maxInactiveRevisions (Azure#20334) * add property: maxInactiveRevisions * update * update * Add premium sku related properties for managed environment (Azure#19770) * Add premium sku related properties for managed environment * Move sku to base property * Add workloadProfileType * Examples for managed environment * Add container app example * Fix workloadProfiles * Add custom word * Fix WorkloadProfileType references * prettier fixes * Fix workload profile * Fix typo * remove readonly property for workload profile * Add object type * nit: Fix description location * Fix XmsIdentifierValidation * Remove spaces from enum values * Remove unwanted change * Add aka ms url * Update examples for workload profile type * Fix rebase issue * Fix json * Update description and move location * Remove provisioning state for node pool * sku capacity explanation * Remove capacity attribute * Remove capacity attribute from required * Mark sku property as required * Add x-ms-identifiers * Rename mimum and maximum * Rename skutype to skuName * Make sku property as optional * Make workload profile type as string * fix go SDK automation config Co-authored-by: Chenjie Shi <[email protected]> * Fix source control status code in 2022-06-01-preview. (Azure#20429) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * Remove 20220501 because we will not support it in server side (Azure#20427) * remove * update * add proxy resource properties * Response formatting * Added support for user defined routing (Azure#20464) * Added support for user defined routing * Added examples * fixed JSON syntax * syntax fix * fixed vnetenvironment syntax * fixed camel case * case fix * enum syntax * fixed comma cases ManagedEnvironmentOutBoundType * fixing casing * add default error response * Add available workprofiles -GET endpoint * Remove duplicate schema name WorkloadProfile * Change memoryGiB to memoryGB as suggested in code review * Add x-ms-pageable - nextLink support to not introduce breaking changes in the future * rename to memory in GiB because our case is Gibibytes base 1024 * change friendlyName to displayName * Some more APIs (Azure#20448) * new APIs to 06-01 * test fix * more fixes * Add new property to the response object * add last active time for revision (Azure#20658) * Add custom domain for connected env (Azure#20731) * add custom domain * fhcekout * billingMeters - GET endpoint (Azure#20485) * Swagger documentation for /locations/{location}/billingMeters - GET endpoint * Add example, fix validation errors * Fix ARM validation errors, code review comments * Fix response validation * add proxy resource properties * Response formatting * add default error response * ARM Review feedback + small naming change for a property * Change GB to GiB * Change the boolean value for default to enum * change error response to v3/ErrorResponse * Fix 2022-06-01-preview branch merge conflicts (Azure#20773) * Reset * more fixes * More fixes * another conflict fix * Fix old preview version * fix 2022-03-01 Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Ruslan Yakushev <[email protected]> Co-authored-by: michimune <[email protected]> Co-authored-by: Michimune Kohno <[email protected]> Co-authored-by: Zunli Hu <[email protected]> Co-authored-by: Mike Vu <[email protected]> Co-authored-by: tombuildsstuff <[email protected]> Co-authored-by: Ahmed ElSayed <[email protected]> Co-authored-by: LaylaLiu-gmail <[email protected]> Co-authored-by: Alessandro (Ale) Segala <[email protected]> Co-authored-by: Mengjun Qin <[email protected]> Co-authored-by: Mengjun Qin <[email protected]> Co-authored-by: Taher Daroly <[email protected]> Co-authored-by: Taher Darolywala <[email protected]> Co-authored-by: zhenqxuMSFT <[email protected]> Co-authored-by: p-bouchon <[email protected]> Co-authored-by: p-bouchon <[email protected]> Co-authored-by: njucz <[email protected]> Co-authored-by: JJ <[email protected]> Co-authored-by: Chenjie Shi <[email protected]> Co-authored-by: yalixiang <[email protected]> Co-authored-by: Mahmoud Desokey <[email protected]> Co-authored-by: Xingjian Wang <[email protected]>
Packages impacted by this PR
@azure/search-documents
Issues associated with this PR
None
Describe the problem that is addressed by this PR
There is a new commit to the Search Swaggers that includes the operations related to aliases. We would like to release them next week.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
No specific design concerns. This is very similar to the previous designs followed in the code.
Are there test cases added in this PR? (If not, why?)
None specifically related to aliases. Will be added soon before the next release.
Provide a list of related PRs (if any)
None
Checklists
@xirzec Please review and approve the PR. Thanks