Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] - Regenerate and prep for release #20650

Merged
merged 6 commits into from
Mar 21, 2022
Merged

[KeyVault] - Regenerate and prep for release #20650

merged 6 commits into from
Mar 21, 2022

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Mar 3, 2022 •
edited
Loading

Packages impacted by this PR

@azure/keyvault-keys
@azure/keyvault-certificates
@azure/keyvault-admin
@azure/keyvault-secrets

Issues associated with this PR

Resolves #18400

Describe the problem that is addressed by this PR

Now that 7.3 swagger is merged, we can regenerate and prep for a release

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@ghost ghost added the KeyVault label Mar 3, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/keyvault-certificates. You can review API changes here

API changes

-     serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3-preview";
+     serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3";

@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/keyvault-secrets. You can review API changes here

API changes

-     serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3-preview";
+     serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3";

@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/keyvault-admin. You can review API changes here

API changes

- LATEST_API_VERSION = "7.3-preview"
+ LATEST_API_VERSION = "7.3"
- export declare type SUPPORTED_API_VERSIONS = "7.2" | "7.3-preview";
+ export declare type SUPPORTED_API_VERSIONS = "7.2" | "7.3";

@maorleger maorleger changed the title [KeyVault] - Regenerate swagger, prep for release [KeyVault] - Regenerate and prep for release Mar 21, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/keyvault-certificates. You can review API changes here

API changes

-     serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3-preview";
+     serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3";
- export declare const enum KnownDeletionRecoveryLevel 
+ export declare enum KnownDeletionRecoveryLevel

@azure-sdk
Copy link
Collaborator

API changes have been detected in @azure/keyvault-secrets. You can review API changes here

API changes

- export declare const enum KnownDeletionRecoveryLevel 
+ export declare enum KnownDeletionRecoveryLevel 
-     serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3-preview";
+     serviceVersion?: "7.0" | "7.1" | "7.2" | "7.3";

@maorleger maorleger marked this pull request as ready for review March 21, 2022 17:38
sadasant
sadasant approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Though the number of changes makes it harder to review this PR 🙂

@maorleger
Copy link
Member Author

/azp run js - keyvault-admin - tests

@maorleger
Copy link
Member Author

/azp run js - keyvault-certificates - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maorleger
Copy link
Member Author

/azp run js - keyvault-keys - tests

@maorleger
Copy link
Member Author

/azp run js - keyvault-secrets - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maorleger maorleger merged commit c6e3a0f into Azure:main Mar 21, 2022
@maorleger maorleger deleted the prep-for-keyvault-ga branch March 21, 2022 21:40
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Sep 28, 2022
@ruslany @michimune
@Juliehzl @vusause @tombuildsstuff @ahmelsayed @LaylaLiu-gmail @ItalyPaleAle @mjqin @tdaroly @zhenqxuMSFT @p-bouchon @njuCZ @jijohn14 @tadelesh @yalixiang @desokey @xwang971
CodeGen from PR 20650 in Azure/azure-rest-api-specs
9431eb1 
Availableworkloadprofiles - GET endpoint (Azure#20650)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <[email protected]>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <[email protected]>
Co-authored-by: Mike Vu <[email protected]>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <[email protected]>
Co-authored-by: tombuildsstuff <[email protected]>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <[email protected]>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <[email protected]>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <[email protected]>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <[email protected]>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <[email protected]>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <[email protected]>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* add proxy resource properties

* Response formatting

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* add default error response

* Add available workprofiles -GET endpoint

* Remove duplicate schema name WorkloadProfile

* Change memoryGiB to memoryGB as suggested in code review

* Add x-ms-pageable - nextLink support to not introduce breaking changes in the future

* rename to memory in GiB because our case is Gibibytes base 1024

* change friendlyName to displayName

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* Add new property to the response object

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Change the boolean value for default to enum

* change error response to v3/ErrorResponse

* Fix 2022-06-01-preview branch merge conflicts (Azure#20773)

* Reset

* more fixes

* More fixes

* another conflict fix

* Fix old preview version

* fix 2022-03-01

Signed-off-by: ItalyPaleAle <[email protected]>
Co-authored-by: Ruslan Yakushev <[email protected]>
Co-authored-by: michimune <[email protected]>
Co-authored-by: Michimune Kohno <[email protected]>
Co-authored-by: Zunli Hu <[email protected]>
Co-authored-by: Mike Vu <[email protected]>
Co-authored-by: tombuildsstuff <[email protected]>
Co-authored-by: Ahmed ElSayed <[email protected]>
Co-authored-by: LaylaLiu-gmail <[email protected]>
Co-authored-by: Alessandro (Ale) Segala <[email protected]>
Co-authored-by: Mengjun Qin <[email protected]>
Co-authored-by: Mengjun Qin <[email protected]>
Co-authored-by: Taher Daroly <[email protected]>
Co-authored-by: Taher Darolywala <[email protected]>
Co-authored-by: zhenqxuMSFT <[email protected]>
Co-authored-by: p-bouchon <[email protected]>
Co-authored-by: p-bouchon <[email protected]>
Co-authored-by: njucz <[email protected]>
Co-authored-by: JJ <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
Co-authored-by: yalixiang <[email protected]>
Co-authored-by: Mahmoud Desokey <[email protected]>
Co-authored-by: Xingjian Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadasant sadasant sadasant approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@xirzec xirzec Awaiting requested review from xirzec

@jeremymeng jeremymeng Awaiting requested review from jeremymeng

Assignees
No one assigned
Labels
KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[KeyVault] - Prepare for GA release
3 participants
@maorleger @azure-sdk @sadasant