Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] - Add release policy grammar links #20941

Merged
merged 2 commits into from
Mar 21, 2022

Conversation

maorleger
Copy link
Member

Packages impacted by this PR

@azure/keyvault-keys

Issues associated with this PR

#18400

Describe the problem that is addressed by this PR

The service team would like to document the release policy grammar, and as such
has asked us to link to their documentation. While the documentation is not live
yet, I did get the content folks to point it to a valid url so that we can
include it in our doc-comments now.

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).

@ghost ghost added the KeyVault label Mar 18, 2022
@maorleger maorleger changed the title [KeyVault] - Add release policy grammar keys [KeyVault] - Add release policy grammar links Mar 18, 2022
/**
* The policy rules under which the key can be released. Encoded based on the {@link KeyReleasePolicy.contentType}.
*
* For more information regarding the release policy grammar for Azure Key Vault, please refer to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"grammar" works, but I wonder if "schema" would be better. It's more oft used. Either is fine, though.

sdk/keyvault/keyvault-keys/src/keysModels.ts Show resolved Hide resolved
@maorleger maorleger merged commit efde84b into Azure:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants