Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] - Prepare for GA release #18400

Closed
6 of 8 tasks
maorleger opened this issue Oct 27, 2021 · 3 comments · Fixed by #20650
Closed
6 of 8 tasks

[KeyVault] - Prepare for GA release #18400

maorleger opened this issue Oct 27, 2021 · 3 comments · Fixed by #20650
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2022] April

Comments

@maorleger
Copy link
Member

maorleger commented Oct 27, 2021 •
edited
Loading

In order to prepare for GA release, ensure the following have been considered for all 4 packages:

  • Regenerate code from the stable 7.3 swagger when available for all 4 libraries
  • API view is approved (all 4 likely will have changes - either due to new RBAC roles or just service version change)
  • Version constants are updated to remove the "-beta.x" suffix
  • Documentation pass: ensure it meets this bar and that generated docs look as expected
  • Ensure release artifacts can be installed cleanly
  • Ensure upgrade path succeeds without breaking changes (use existing GA package, run a few well-known scenarios, then upgrade and rerun)
  • Ensure any language-specific necessary action items have been added and addressed
  • Regenerate samples
@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. KeyVault labels Oct 27, 2021
@maorleger maorleger added this to the [2021] December milestone Oct 27, 2021
@maorleger maorleger self-assigned this Oct 27, 2021
@maorleger
Copy link
Member Author

Due in February, since the stable swagger won't be available until mid-january

@maorleger
Copy link
Member Author

The service team pushed the release back

@maorleger maorleger modified the milestones: [2022] April, [2022] March Jan 13, 2022
@maorleger maorleger mentioned this issue Mar 3, 2022
Merged
3 tasks
@maorleger maorleger modified the milestones: [2022] March, [2022] April Mar 14, 2022
This was referenced Mar 18, 2022
Merged
Merged
maorleger added a commit that referenced this issue Mar 21, 2022
@maorleger
[KeyVault] - Add release policy grammar links (#20941)
efde84b 
### Packages impacted by this PR
@azure/keyvault-keys

### Issues associated with this PR
#18400

### Describe the problem that is addressed by this PR
The service team would like to document the release policy grammar, and as such
has asked us to link to their documentation. While the documentation is not live
yet, I did get the content folks to point it to a valid url so that we can
include it in our doc-comments now.
@maorleger
Copy link
Member Author

You can use Azure/azure-rest-api-specs@e2ef44b to regenerate from

maorleger added a commit that referenced this issue Mar 21, 2022
@maorleger
[KeyVault] - Regenerate and prep for release (#20650)
c6e3a0f 
### Packages impacted by this PR
@azure/keyvault-keys 
@azure/keyvault-certificates
@azure/keyvault-admin 
@azure/keyvault-secrets

### Issues associated with this PR
Resolves #18400

### Describe the problem that is addressed by this PR
Now that 7.3 swagger is merged, we can regenerate and prep for a release
@maorleger maorleger mentioned this issue Mar 25, 2022
Merged
3 tasks
maorleger added a commit that referenced this issue Mar 25, 2022
@maorleger
[KeyVault] - Publish samples post-release (#21040)
7a03d94 
### Packages impacted by this PR
@azure/keyvault-admin
@azure/keyvault-certificates
@azure/keyvault-keys
@azure/keyvault-secrets

### Issues associated with this PR
#18400

### Describe the problem that is addressed by this PR
Now that KV GA is released we can update the samples so that we include the key
rotation samples. In-passing, I regenerated all keyvault samples to take in any
changes from dev-tool.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2022] April
Development

Successfully merging a pull request may close this issue.

[KeyVault] - Regenerate and prep for release maorleger/azure-sdk-for-js
1 participant
@maorleger