[Language Text] Introduce the library #22640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
force-pushed
the
textanalysis/create-new-package
branch
from
cca09c5
to
b6bf136
Compare
deyaaeldeen
requested review from
witemple-msft,
mikeharder,
praveenkuttappan,
jeremymeng,
benbp,
bterlson and
xirzec
as code owners
|
/azp run js - cognitivelanguage - ci |
|
No pipelines are associated with this pull request. |
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - cognitivelanguage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kristapratico
approved these changes
Jul 20, 2022
| @@ -0,0 +1,5 @@ | |||
| # Release History | |||
|
|
|||
| ## 1.0.0-beta.1 (Unreleased) | |||
There was a problem hiding this comment.
I think when creating a new package we try to have the new version be greater than the old version. Not sure if this was written into guidelines, but might be worth checking.
There was a problem hiding this comment.
Good point, I started an email thread about this and can address the issue in another PR.
|
/check-enforcer override |
deyaaeldeen
added a commit
that referenced
this pull request
Jul 24, 2022
Resets the code base for the Text Analytics library to the one used to release v5.1.0. The reset was done by checking out the library folder from the github tag for the v5.1.0 release. However, I updated the code base to use @azure/core-tracing@^1.0.0 too. This is needed because v6.0.0-beta.1 has been moved in #22640 into a new package: @azure/ai-language-text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The archboard recommended creating a new library for the Language Text Analysis service and this PR copies the codebase of @azure/ai-text-analytics into the new @azure/ai-language-text. The only other change the PR makes is updating all the names/references accordingly. Please note that link verification will fail for many links that don't exist on the main branch yet and I plan to override it to get the PR merged.
TODO:
add configs for CI and resource creation