Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Board Review: @azure/[email protected] #4339

Closed
deyaaeldeen opened this issue May 21, 2022 · 3 comments
Closed

Board Review: @azure/[email protected] #4339

deyaaeldeen opened this issue May 21, 2022 · 3 comments
Assignees
Labels
architecture board-review Request for an Architectural Board Review Cognitive - Text Analytics

Comments

@deyaaeldeen
Copy link
Member

deyaaeldeen commented May 21, 2022

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.

The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.

Please reference our review process guidelines to understand what is being asked for in the issue template.

To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together. In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.

For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.

Before submitting, ensure you adjust the title of the issue appropriately.

Note that the required material must be included before a meeting can be scheduled.

Contacts and Timeline

  • Responsible service team: Azure Cognitive Language
  • Main contacts: @deyaaeldeen
  • Expected code complete date: August 2022
  • Expected release date: August 2022

About the Service

About the client library

  • Name of the client library: @azure/ai-text-analytics
  • Languages for this review: JavaScript

Artifacts required (per language)

Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.

.NET

  • APIView Link:
  • Link to Champion Scenarios/Quickstart samples:

Java

  • APIView Link:
  • Link to Champion Scenarios/Quickstart samples:

Python

  • APIView Link:
  • Link to Champion Scenarios/Quickstart samples:

TypeScript

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.

Thank you!

@deyaaeldeen deyaaeldeen added architecture board-review Request for an Architectural Board Review labels May 21, 2022
@deyaaeldeen deyaaeldeen changed the title Board Review: @azure/ai-text-analytics Board Review: @azure/[email protected] May 21, 2022
@kyle-patterson
Copy link
Member

Scheduled for 6/20

@kyle-patterson
Copy link
Member

Rescheduled for 6/23

@srnagar
Copy link
Member

srnagar commented Jun 23, 2022

Recording (MS INTERNAL ONLY)

deyaaeldeen added a commit to Azure/azure-sdk-for-js that referenced this issue Jul 21, 2022
The [archboard recommended](Azure/azure-sdk#4339) creating a new library for the Language Text Analysis service and this PR copies the codebase of @azure/ai-text-analytics into the new @azure/ai-language-text. The only other change the PR makes is updating all the names/references accordingly. Please note that link verification will fail for many links that don't exist on the main branch yet and I plan to override it to get the PR merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture board-review Request for an Architectural Board Review Cognitive - Text Analytics
Projects
None yet
Development

No branches or pull requests

4 participants