Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support key export from Key Vault #14892

Closed
6 tasks done
heaths opened this issue Sep 4, 2020 · 1 comment · Fixed by #16794
Closed
6 tasks done

Support key export from Key Vault #14892

heaths opened this issue Sep 4, 2020 · 1 comment · Fixed by #16794
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2020] November

Comments

@heaths
Copy link
Member

heaths commented Sep 4, 2020 •
edited
Loading

For Key Vault 7.2-preview, we need to add support to export keys. This would be a method like KeyClient.ExportKey that takes the key name, key version (both required), and a body with the KeyExportParameters model found in the link below. This only has a single required property named environment (model property: env), so we should take this as a parameter. This returns a KeyVaultKey (model KeyBundle).

This requires a number of other changes:

  • Add optional Exportable boolean property to KeyProperties.
  • Add ReleasePolicy property to KeyProperties of type KeyReleasePolicy.
  • Add PublicExponent integer property to CreateKeyOptions.
  • Add "export" to KeyOperation enum. This will correctly impact the CreateKeyOptions class and the KeyClient.UpdateKey method..
  • Add ReleasePolicy property to CreateKeyOptions.
  • Add ReleasePolicy property to ImportKeyOptions.

See the service version 7.1 -> 7.2-preview diff 🔒 for details.
@heaths heaths added KeyVault Client This issue points to a problem in the data-plane of the library. labels Sep 4, 2020
@heaths heaths added this to the [2020] October milestone Sep 4, 2020
@heaths heaths mentioned this issue Sep 10, 2020
Closed
1 task
@heaths heaths mentioned this issue Sep 16, 2020
Closed
@heaths heaths added the blocking-release Blocks release label Sep 16, 2020
@heaths
Copy link
Member Author

heaths commented Sep 16, 2020

Key Vault is considering a change to the models that will require significant code changes so I'm putting this on hold.

@heaths heaths modified the milestones: [2020] October, [2020] November Oct 5, 2020
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Oct 14, 2020
@heaths
WIP: Implement secure key release
fa7f009 
Resolves Azure#14892
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Nov 10, 2020
@heaths
Implement secure key release
7865506 
Resolves Azure#14892 sans tests; see Azure#16789 and Azure#16792
@heaths heaths mentioned this issue Nov 10, 2020
Merged
heaths added a commit that referenced this issue Nov 11, 2020
@heaths
Implement secure key release (#16794)
859f046 
* Doc comment and scope name improvements

* Implement secure key release

Resolves #14892 sans tests; see #16789 and #16792

* Update public APIs
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this issue Feb 17, 2021
@heaths @annelo-msft
Implement secure key release (Azure#16794)
626bc6c 
* Doc comment and scope name improvements

* Implement secure key release

Resolves Azure#14892 sans tests; see Azure#16789 and Azure#16792

* Update public APIs
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2020] November
1 participant
@heaths