Implement secure key release #16794
Merged
Implement secure key release #16794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves Azure#14892 sans tests; see Azure#16789 and Azure#16792
ghost
added
the
christothes
approved these changes
Nov 10, 2020
|
FWIW, I did write some tests that failed because the service hasn't implemented it as spec'd in the swagger, but I did examine the test recordings and request/response models were correct as spec'd. @herveyw-msft do you want us to go ahead and check this in, then? /cc @vcolin7 |
|
I spoke with Vick offline and, yes, we will merge this. It may not work for a while, but should eventually. |
|
@vcolin7 could you at least review https://github.com/Azure/azure-sdk-for-net/pull/16794/files#diff-a5a8d91de8e78a2e9da740239ab1cf5c214ad8e30567fe1820465113c9b425fa and make sure that looks like what you expected given our conversations? |
vcolin7
reviewed
Nov 10, 2020
sdk/keyvault/Azure.Security.KeyVault.Keys/api/Azure.Security.KeyVault.Keys.netstandard2.0.cs
Show resolved
Hide resolved
sdk/keyvault/Azure.Security.KeyVault.Keys/api/Azure.Security.KeyVault.Keys.netstandard2.0.cs
Show resolved
Hide resolved
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
* Doc comment and scope name improvements * Implement secure key release Resolves Azure#14892 sans tests; see Azure#16789 and Azure#16792 * Update public APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14892 sans tests; see #16789 and #16792