Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] Add type to FormField #12561

Merged
merged 7 commits into from
Jul 21, 2020
Merged

[formrecognizer] Add type to FormField #12561

merged 7 commits into from
Jul 21, 2020

Conversation

kristapratico
Copy link
Member

No description provided.

@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer labels Jul 15, 2020
@kristapratico kristapratico self-assigned this Jul 15, 2020
@kristapratico kristapratico marked this pull request as ready for review July 17, 2020 15:29
iscai-msft
iscai-msft previously approved these changes Jul 20, 2020
View reviewed changes
sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_models.py Outdated
:ivar ~azure.ai.formrecognizer.FieldData label_data:
Contains the text, bounding box, and field elements for the field label.
:ivar ~azure.ai.formrecognizer.FieldData value_data:
Contains the text, bounding box, and field elements for the field value.
:ivar str name: The unique name of the field or label.
:ivar value:
The value for the recognized field. Possible types include: 'string',
'date', 'time', 'phoneNumber', 'number', 'integer', 'object', or 'array'.
The value for the recognized field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would somehow link this to the variable type. Something along the lines of
"The value for the recognized field. It's data type is described in type"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added!

iscai-msft
iscai-msft approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kristapratico kristapratico merged commit 84e085d into Azure:master Jul 21, 2020
@kristapratico kristapratico deleted the add-fieldtype branch July 21, 2020 15:31
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 21, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
e9cbd87 
…into ta_opinion_mining_sample

* 'master' of https://github.com/Azure/azure-sdk-for-python: (124 commits)
  [formrecognizer] Add type to FormField (Azure#12561)
  Add example summary for azure-identity readme.md (Azure#12509)
  Add logging to credentials (Azure#12319)
  Sdk automation/track2 azure mgmt keyvault (Azure#12638)
  Remove unnecessary coroutine declaration (Azure#12602)
  [Cosmos] Fix type comment (Azure#12598)
  replace aka link (Azure#12597)
  [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451)
  Find list of installed packages using pkg_resources (Azure#12591)
  token refresh offset (Azure#12136)
  updates (Azure#12595)
  User authentication samples (Azure#11343)
  Remove unnecessary base class (Azure#12374)
  Sequence -> Iterable for scopes (Azure#12579)
  Disable apistubgen step until issue is fixed (Azure#12594)
  fix pylint issue (Azure#12578)
  fix name in example (Azure#12572)
  Update tests.md (Azure#12574)
  Add stress tests for max batch size/prefetch, and for unsettled message receipt.  Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344)
  [formrecognizer] Capitalize enum values (Azure#12540)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 29, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
e1f08b2 
…into regenerate_keys

* 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits)
  rename FormField.type -> FormField.value_type (Azure#12708)
  20200703 codereport (Azure#12361)
  Use the common Cosmos emulator template. (Azure#12678)
  Add azurestackhci ci.yml for pipeline generation. (Azure#12701)
  [ServiceBus] Resend received message (Azure#12457)
  AZURE_CLIENT_ID sets user-assigned managed identity for DefaultAzureCredential (Azure#12689)
  Add better autolockrenew on-failure handling capabilities. (Azure#12307)
  Update CODEOWNERS (Azure#12418)
  close client session in async tests (Azure#12656)
  Sync eng/common directory with azure-sdk-tools repository (Azure#12502)
  [Event Hubs] Use EventHubManagementClient to create test resources (Azure#12501)
  Increment package version after release of azure_identity (Azure#12675)
  [formrecognizer] include error code for errors that occur during polling (Azure#12621)
  Cross-language consistency changes (Azure#12669)
  Enable APIStubGen step (Azure#12615)
  Adding the ability to create a container with analytical storage turned on. (Azure#12408)
  [ServiceBus] Adjust user-agent following the guideline (Azure#12596)
  Release for Cognitive Services - Anomaly Detector (Azure#12582)
  [formrecognizer] Add type to FormField (Azure#12561)
  Add example summary for azure-identity readme.md (Azure#12509)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees

@kristapratico kristapratico

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristapratico @iscai-msft