Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary coroutine declaration #12602

Merged
merged 1 commit into from
Jul 20, 2020
Merged

Remove unnecessary coroutine declaration #12602

merged 1 commit into from
Jul 20, 2020

Conversation

chlowell
Copy link
Member

pytest doesn't execute this test because it's a coroutine but not marked as such. It doesn't await anything, so I just removed the async declaration.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Jul 17, 2020
@chlowell chlowell requested a review from xiangyan99 July 17, 2020 22:49
@chlowell chlowell requested a review from schaabs as a code owner July 17, 2020 22:49
@chlowell chlowell merged commit 062062f into Azure:master Jul 20, 2020
@chlowell chlowell deleted the test-fix branch July 20, 2020 22:34
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 21, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
e9cbd87 
…into ta_opinion_mining_sample

* 'master' of https://github.com/Azure/azure-sdk-for-python: (124 commits)
  [formrecognizer] Add type to FormField (Azure#12561)
  Add example summary for azure-identity readme.md (Azure#12509)
  Add logging to credentials (Azure#12319)
  Sdk automation/track2 azure mgmt keyvault (Azure#12638)
  Remove unnecessary coroutine declaration (Azure#12602)
  [Cosmos] Fix type comment (Azure#12598)
  replace aka link (Azure#12597)
  [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451)
  Find list of installed packages using pkg_resources (Azure#12591)
  token refresh offset (Azure#12136)
  updates (Azure#12595)
  User authentication samples (Azure#11343)
  Remove unnecessary base class (Azure#12374)
  Sequence -> Iterable for scopes (Azure#12579)
  Disable apistubgen step until issue is fixed (Azure#12594)
  fix pylint issue (Azure#12578)
  fix name in example (Azure#12572)
  Update tests.md (Azure#12574)
  Add stress tests for max batch size/prefetch, and for unsettled message receipt.  Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344)
  [formrecognizer] Capitalize enum values (Azure#12540)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chlowell @xiangyan99