Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] CI Test hotfixes #14195

Merged
merged 3 commits into from
Oct 2, 2020
Merged

[ServiceBus] CI Test hotfixes #14195

merged 3 commits into from
Oct 2, 2020

Conversation

KieranBrantnerMagee
Copy link
Member

@KieranBrantnerMagee KieranBrantnerMagee commented Oct 2, 2020 •
edited
Loading

Fix preparer fallback conditional.

  • the special case was written for cosmos in their preparer adoption, for an edge case that is hit for some tests that did not have recordings.
  • However, the live_test flag did not behave as expected on servicebus live tests, and the proper semantic live check (seen here) needed to be substituted.

Edit: (moving this from a comment to head so reviewers note it)
A few notes.

  • Spoke with @seankane-msft about the table failure, this has been red for some time and is being triaged actively. Sean reported validating the tests with this branch independently for tables and had confidence that the remaining failures were table-specific.
  • The debugging printouts present will be removed once folks have seen the set of green CI and test runs and confirmed that they feel comfortable with this level of coverage.

@KieranBrantnerMagee KieranBrantnerMagee added Service Bus EngSys This issue is impacting the engineering system. labels Oct 2, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] October milestone Oct 2, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Oct 2, 2020
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
try using testclassinstance islive as a more proper approach. if this…
93c11eb 
… doesn't work, may try a devtoolsutils import in a try catch as a final hail mairy for is_live() to match the decorator itself.
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - tables - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - formrecognizer - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

A few notes.

  1. Spoke with @seankane-msft about the table failure, this has been red for some time and is being triaged actively. Sean reported validating the tests with this branch independently for tables and had confidence that the remaining failures were table-specific.
  2. The debugging printouts present will be removed once folks have seen the set of green CI and test runs and confirmed that they feel comfortable with this level of coverage.

@KieranBrantnerMagee KieranBrantnerMagee marked this pull request as ready for review October 2, 2020 18:50
@KieranBrantnerMagee KieranBrantnerMagee changed the title [ServiceBus] [IgnoreMe] CI Test hotfixes [ServiceBus] CI Test hotfixes Oct 2, 2020
seankane-msft
seankane-msft previously approved these changes Oct 2, 2020
View reviewed changes
@KieranBrantnerMagee KieranBrantnerMagee mentioned this pull request Oct 2, 2020
Closed
@yunhaoling
Copy link
Contributor

(I'm an idiot, I have a separate chrome opened with another gh accout and clicked the approve button, ignore my approval from gnilmada )

@KieranBrantnerMagee
Copy link
Member Author

See I just took it as we had a guardian angel reading our PRs... :P

(joking aside, storage - ci is a known failure that storage team is triaging, have engaged @rakshith91 who kindly helped confirm. since we're coming down to the wire, pushing this in with other tests happy.)

@lmazuel
Copy link
Member

lmazuel commented Oct 2, 2020

Force merging the PR, since failing for unrelated reasons

@lmazuel lmazuel merged commit 5c56b81 into Azure:master Oct 2, 2020
iscai-msft added a commit that referenced this pull request Oct 7, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
827d37e 
…into fr-business-cards

* 'master' of https://github.com/Azure/azure-sdk-for-python: (71 commits)
  move the environment prep above the tooling that needs it (#14246)
  Increment version for appconfiguration releases (#14245)
  Azure Communication Service - Phone Number Administration (#14237)
  [text analytics] fix query param in cli call to get endpoint (#14243)
  Resolve Failing Documentation Build for azure-mgmt-core (#14239)
  Add code reviewers (#14229)
  [ServiceBus] make amqp_message properties read-only (#14095)
  [ServiceBus]remove topic parameter object settability (#14116)
  app config owner (#12986)
  [KeyVault] Handle Role Definition UUID Name Internally (#14218)
  Increment version for storage releases (#14224)
  Update Key Vault changelogs for October release (#14226)
  [ServiceBus] CI Test hotfixes (#14195)
  [text analytics] regen TA with GA autorest (#14215)
  [Storage][STG74]ChangeLog (#14192)
  fixes python 2.7 issue with unicode and strings again! (#14216)
  Feature/storage stg74 (#14175)
  Update communication pacakges to version b2 (#14209)
  [KeyVault] Add Status Methods to Query Backup and Restore Operations (#14158)
  Update buffered sender (#13851)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

@gnilmada gnilmada gnilmada approved these changes

@seankane-msft seankane-msft seankane-msft left review comments

@lmazuel lmazuel Awaiting requested review from lmazuel

@annatisch annatisch Awaiting requested review from annatisch

Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
EngSys This issue is impacting the engineering system. Service Bus
Projects
None yet
Milestone
[2020] October
Development

Successfully merging this pull request may close these issues.
5 participants
@KieranBrantnerMagee @yunhaoling @lmazuel @seankane-msft @gnilmada