Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] CI Test hotfixes #14195

Merged
merged 3 commits into from
Oct 2, 2020
Merged

[ServiceBus] CI Test hotfixes #14195

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea44afa
See if we can identify why the preparer is going sideways with the co…
KieranBrantnerMagee Oct 2, 2020
93c11eb
try using testclassinstance islive as a more proper approach. if thi…
KieranBrantnerMagee Oct 2, 2020
c95db8e
Remove debug prints from preparer hotfix
KieranBrantnerMagee Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/azure-devtools/src/azure_devtools/scenario_tests/preparers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def _prepare_create_resource(self, test_class_instance, **kwargs):
# generated, so in_recording will be True even if live_test is false, so a random name would be given.
# In cached mode we need to avoid this because then for tests with recordings, they would not have a moniker.
if (self.live_test or test_class_instance.in_recording) \
and not (not self.live_test and test_class_instance.in_recording and self._use_cache):
and not (not test_class_instance.is_live and test_class_instance.in_recording and self._use_cache):
resource_name = self.random_name
if not self.live_test and isinstance(self, RecordingProcessor):
test_class_instance.recording_processors.append(self)
Expand Down