Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] cognitiveservices/data-plane/ComputerVision #2614

Merged

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: cognitiveservices/data-plane/ComputerVision

@AutorestCI
Copy link
Contributor Author

AutorestCI commented May 23, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-cognitiveservices-vision-computervision

You can install the package azure-cognitiveservices-vision-computervision of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_cognitiveservices/data-plane/ComputerVision#egg=azure-cognitiveservices-vision-computervision&subdirectory=azure-cognitiveservices-vision-computervision"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_cognitiveservices/data-plane/ComputerVision#egg=azure-cognitiveservices-vision-computervision&subdirectory=azure-cognitiveservices-vision-computervision"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_cognitiveservices/data-plane/ComputerVision
  • pip install -e ./azure-cognitiveservices-vision-computervision

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_cognitiveservices/data-plane/ComputerVision
  • pip wheel --no-deps ./azure-cognitiveservices-vision-computervision

Package azure-sdk-tools

You can install the package azure-sdk-tools of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_cognitiveservices/data-plane/ComputerVision#egg=azure-sdk-tools&subdirectory=azure-sdk-tools"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_cognitiveservices/data-plane/ComputerVision#egg=azure-sdk-tools&subdirectory=azure-sdk-tools"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_cognitiveservices/data-plane/ComputerVision
  • pip install -e ./azure-sdk-tools

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_cognitiveservices/data-plane/ComputerVision
  • pip wheel --no-deps ./azure-sdk-tools

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented May 23, 2018

Codecov Report

Merging #2614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2614   +/-   ##
=======================================
  Coverage   56.11%   56.11%           
=======================================
  Files        7403     7403           
  Lines      154782   154782           
=======================================
  Hits        86858    86858           
  Misses      67924    67924

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 223ddb6...d5038d0. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented Jun 21, 2018

@AutorestCI rebase

Update CognitiveService ComputerVision Swagger for new extensions (#1)

* Merged PR 17875: Add new languages

Add new languages

Also tidy up the enum definition so that AutoRest generates C# that actually compiles

* Merged PR 17942: Replace fancy quotes with plain single quotes

Make javac compile without complaint even without setting the codepage to utf-8 by dropping the gratuitous typographic quotes.

* Merged PR 17956: Rename url argument for overloaded endpoint to imageUrl

This name will become the name of the argument in Python.  Since you can used named arguments in Python, give them less ambiguous names.

* Changes to make --azure-validator run more cleanly

Errors Fixed
* XmsExamplesRequired/D5001/Documentation (7)
* XmsPathsMustOverloadPaths/R2058/SDKViolation (7)

Errors Ignored
* SecurityDefinitionsStructure/R2054/SDKViolation (1) - API Key scheme for Cognitive Services
* APIVersionPattern/R3012/ARMViolation (1) - Keeping with the Cognitive Services numbering scheme
* OperationsAPIImplementation/R3023/ARMViolation (1) - Not sure what this is

Warnings Fixed
* XmsEnumValidation/R2018/SDKViolation (1)
* DescriptionAndTitleMissing/R4000/SDKViolation (1)

Warnings Ignored
* DescriptionAndTitleMissing/R4000/SDKViolation (35) - description is contained in #ref
* EnumInsteadOfBoolean/R3018/ARMViolation (5) - fix would be a breaking change
* ListInOperationName/R1003/SDKViolation (1) - fix would be a breaking change
* LongRunningOperationsWithLongRunningExtension/R2007/SDKViolation (2) - endpoint will not ultimately yield a 200, as this extension would require
* NonApplicationJsonType/R2004/ARMViolation (15) - fix would be breaking change
* PageableOperation/R2029/SDKViolation (1) - not actually pageable
* ParameterNotDefinedInGlobalParameters/R2015/SDKViolation (1) - All our own parameters specify x-ms-parameter-location
* PostOperationIdContainsUrlVerb/R2066/SDKViolation (7) - fix would be breaking change
ComputerVision - collection of fixes

* fix ocr language parameter to fix [bug](Azure/azure-sdk-for-net#4083)
* language parameter missing for /tag path
* language parameter missing for /models/*/analyze path
* make /models/*/analyze return a more generic type
* add specific types for /models/*/analyze to return for current models
Add Spanish as an option as ServiceLanguage for ComputerVision.
…Service ComputerVision API to V2 (#2747)

* Generated from c2567da015994dac3301f495b6c5011d28ceaffe

Add post-processing directive to swap argument order for RecognizeText to position the url argument ahead of the mode argument.

autorest does not generate the intended order, so we add a post-processing directive,
for each target language,

* Generated from 973322cfd6ec2ced60a732f53b5318ceded5de7b

Fix validation errors

* Generated from 70efe042d607cbd973734e432da395ed35191a03

Add Spanish support for ServiceLanguage

This is for parity with V1.
ComputerVision add tag.hint

Hints provided additional info for whole-image analysis tags.
This PR is to make the Swagger match the service behavior.
@AutorestCI
Copy link
Contributor Author

Rebase done and pushed to the branch

@AutorestCI AutorestCI force-pushed the restapi_auto_cognitiveservices/data-plane/ComputerVision branch from da52829 to 6b6469b Compare June 21, 2018 23:53
@lmazuel lmazuel merged commit 41e37c8 into master Jun 22, 2018
@lmazuel lmazuel deleted the restapi_auto_cognitiveservices/data-plane/ComputerVision branch June 22, 2018 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants