Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR cognitiveservices/data-plane/ComputerVision] Update CognitiveService ComputerVision API to V2 #2747

Conversation

AutorestCI
Copy link
Contributor

Add post-processing directive to swap argument order for RecognizeText to position the url argument ahead of the mode argument.

autorest does not generate the intended order, so we add a post-processing directive,
for each target language,
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Jun 14, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-cognitiveservices-vision-computervision

You can install the package azure-cognitiveservices-vision-computervision of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3236#egg=azure-cognitiveservices-vision-computervision&subdirectory=azure-cognitiveservices-vision-computervision"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3236#egg=azure-cognitiveservices-vision-computervision&subdirectory=azure-cognitiveservices-vision-computervision"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_3236
  • pip install -e ./azure-cognitiveservices-vision-computervision

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_3236
  • pip wheel --no-deps ./azure-cognitiveservices-vision-computervision

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Jun 14, 2018

Codecov Report

Merging #2747 into restapi_auto_cognitiveservices/data-plane/ComputerVision will increase coverage by 0.49%.
The diff coverage is n/a.

Impacted file tree graph

@@                                     Coverage Diff                                      @@
##           restapi_auto_cognitiveservices/data-plane/ComputerVision    #2747      +/-   ##
============================================================================================
+ Coverage                                                     55.71%   56.21%   +0.49%     
============================================================================================
  Files                                                          7377     6419     -958     
  Lines                                                        160539   139763   -20776     
============================================================================================
- Hits                                                          89447    78567   -10880     
+ Misses                                                        71092    61196    -9896
Impacted Files Coverage Δ
...-monitor/azure/mgmt/monitor/models/resource_py3.py 45.45% <0%> (-54.55%) ⬇️
...-batchai/azure/mgmt/batchai/models/resource_py3.py 45.45% <0%> (-54.55%) ⬇️
...ure-mgmt-sql/azure/mgmt/sql/models/resource_py3.py 55.55% <0%> (-44.45%) ⬇️
...on/azure/mgmt/datamigration/models/resource_py3.py 55.55% <0%> (-44.45%) ⬇️
...e/mgmt/datamigration/models/connection_info_py3.py 60% <0%> (-40%) ⬇️
.../mgmt/datamigration/models/tracked_resource_py3.py 62.5% <0%> (-37.5%) ⬇️
...-sql/azure/mgmt/sql/models/tracked_resource_py3.py 62.5% <0%> (-37.5%) ⬇️
...tamigration/models/sql_migration_task_input_py3.py 62.5% <0%> (-37.5%) ⬇️
.../azure/mgmt/monitor/models/rule_data_source_py3.py 66.66% <0%> (-33.34%) ⬇️
...or/azure/mgmt/monitor/models/rule_condition_py3.py 66.66% <0%> (-33.34%) ⬇️
... and 1558 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 835f9e5...50884f5. Read the comment docs.

Add Spanish support for ServiceLanguage

This is for parity with V1.
@AutorestCI AutorestCI merged commit e0d7c52 into restapi_auto_cognitiveservices/data-plane/ComputerVision Jun 15, 2018
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #2614

AutorestCI added a commit that referenced this pull request Jun 21, 2018
…Service ComputerVision API to V2 (#2747)

* Generated from c2567da015994dac3301f495b6c5011d28ceaffe

Add post-processing directive to swap argument order for RecognizeText to position the url argument ahead of the mode argument.

autorest does not generate the intended order, so we add a post-processing directive,
for each target language,

* Generated from 973322cfd6ec2ced60a732f53b5318ceded5de7b

Fix validation errors

* Generated from 70efe042d607cbd973734e432da395ed35191a03

Add Spanish support for ServiceLanguage

This is for parity with V1.
lmazuel pushed a commit that referenced this pull request Jun 22, 2018
* Generated from 984c12a568b2dd36acb521eb3b1c00fbd5b42995 (#2575)

Update CognitiveService ComputerVision Swagger for new extensions (#1)

* Merged PR 17875: Add new languages

Add new languages

Also tidy up the enum definition so that AutoRest generates C# that actually compiles

* Merged PR 17942: Replace fancy quotes with plain single quotes

Make javac compile without complaint even without setting the codepage to utf-8 by dropping the gratuitous typographic quotes.

* Merged PR 17956: Rename url argument for overloaded endpoint to imageUrl

This name will become the name of the argument in Python.  Since you can used named arguments in Python, give them less ambiguous names.

* Changes to make --azure-validator run more cleanly

Errors Fixed
* XmsExamplesRequired/D5001/Documentation (7)
* XmsPathsMustOverloadPaths/R2058/SDKViolation (7)

Errors Ignored
* SecurityDefinitionsStructure/R2054/SDKViolation (1) - API Key scheme for Cognitive Services
* APIVersionPattern/R3012/ARMViolation (1) - Keeping with the Cognitive Services numbering scheme
* OperationsAPIImplementation/R3023/ARMViolation (1) - Not sure what this is

Warnings Fixed
* XmsEnumValidation/R2018/SDKViolation (1)
* DescriptionAndTitleMissing/R4000/SDKViolation (1)

Warnings Ignored
* DescriptionAndTitleMissing/R4000/SDKViolation (35) - description is contained in #ref
* EnumInsteadOfBoolean/R3018/ARMViolation (5) - fix would be a breaking change
* ListInOperationName/R1003/SDKViolation (1) - fix would be a breaking change
* LongRunningOperationsWithLongRunningExtension/R2007/SDKViolation (2) - endpoint will not ultimately yield a 200, as this extension would require
* NonApplicationJsonType/R2004/ARMViolation (15) - fix would be breaking change
* PageableOperation/R2029/SDKViolation (1) - not actually pageable
* ParameterNotDefinedInGlobalParameters/R2015/SDKViolation (1) - All our own parameters specify x-ms-parameter-location
* PostOperationIdContainsUrlVerb/R2066/SDKViolation (7) - fix would be breaking change

* Generated from bd6c66b615b94480a1458dde3a8bc42f3a689548 (#2645)

ComputerVision - collection of fixes

* fix ocr language parameter to fix [bug](Azure/azure-sdk-for-net#4083)
* language parameter missing for /tag path
* language parameter missing for /models/*/analyze path
* make /models/*/analyze return a more generic type
* add specific types for /models/*/analyze to return for current models

* Generated from b35c48945774ac7be9bf0fa05e19c0890141bb3d (#2731)

Add Spanish as an option as ServiceLanguage for ComputerVision.

* [AutoPR cognitiveservices/data-plane/ComputerVision] Update CognitiveService ComputerVision API to V2 (#2747)

* Generated from c2567da015994dac3301f495b6c5011d28ceaffe

Add post-processing directive to swap argument order for RecognizeText to position the url argument ahead of the mode argument.

autorest does not generate the intended order, so we add a post-processing directive,
for each target language,

* Generated from 973322cfd6ec2ced60a732f53b5318ceded5de7b

Fix validation errors

* Generated from 70efe042d607cbd973734e432da395ed35191a03

Add Spanish support for ServiceLanguage

This is for parity with V1.

* Generated from 6492fb4e04a3e5d7330ceccbb9f67e2a839e2290 (#2775)

ComputerVision add tag.hint

Hints provided additional info for whole-image analysis tags.
This PR is to make the Swagger match the service behavior.

* Update version.py

* ComputerVision 0.2.0 packaging
@lmazuel lmazuel deleted the restapi_auto_3236 branch August 1, 2018 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants