Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs onboarding v2 cleanup tasks #6800

Closed
6 tasks done
danieljurek opened this issue Aug 17, 2023 · 2 comments · Fixed by #9057
Closed
6 tasks done

Docs onboarding v2 cleanup tasks #6800

danieljurek opened this issue Aug 17, 2023 · 2 comments · Fixed by #9057
Assignees
@danieljurek
Labels
Docs

Comments

@danieljurek
Copy link
Member

danieljurek commented Aug 17, 2023 •
edited
Loading

Cleanup tasks:

  • - Delete onboarding-specific code from Language-Settings.ps1
  • - Move validation code to Docs-Onboarding.ps1
  • - Remove Update-DocsMsPackages.ps1 (the old v1)
  • - Rename method with trailing 2 in Update-DocsMsPackages.ps1
  • - Migrate package names from .txt file to metadata JSON file for Java
  • - Investigate deprecated packages whose metadata JSONs don't match the versions
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 17, 2023
@danieljurek danieljurek mentioned this issue Aug 17, 2023
Merged
This was referenced Aug 17, 2023
Merged
Merged
Merged
Merged
@JimSuplizio JimSuplizio removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 17, 2023
danieljurek added a commit to Azure/azure-sdk-for-js that referenced this issue Aug 23, 2023
@danieljurek
Docs onboarding v2 (#26682)
9faa6c6 
Requires eng/common changes in
Azure/azure-sdk-tools#6632.
Note: There's also a cleanup
[PR](Azure/azure-sdk-tools#6800) to cleanup
older language specific items.

Test run of
docindex:https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2970911&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739

Converts a collection of metadata JSON files into an onboarding spec.
dgetu pushed a commit to Azure/azure-sdk-for-js that referenced this issue Sep 6, 2023
@danieljurek @dgetu
Docs onboarding v2 (#26682)
c33c612 
Requires eng/common changes in
Azure/azure-sdk-tools#6632.
Note: There's also a cleanup
[PR](Azure/azure-sdk-tools#6800) to cleanup
older language specific items.

Test run of
docindex:https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2970911&view=logs&j=dc056dfc-c0cf-5958-c8c4-8da4f91a3739

Converts a collection of metadata JSON files into an onboarding spec.
@danieljurek
Copy link
Member Author

Still some work to do here but don't want to cause merge conflicts for Python and Java which have PRs in flight.

@JimSuplizio
Copy link
Member

I checked the checkbox for "Migrate package names from .txt file to metadata JSON file for Java" which was fixed with the following PRs

  1. azure-sdk-for-java - Put the namespaces(packages) into the json files
  2. azure-docs-sdk-java - Remove defunct .txt files and template libraries added via testing

This was referenced Sep 24, 2024
Merged
Merged
Merged
danieljurek added a commit to Azure/azure-sdk-for-js that referenced this issue Sep 26, 2024
@danieljurek
Docs cleanup (#31215)
1448442 
Last part of Azure/azure-sdk-tools#6800 that
still needs to be done in JS

Move validation functions from Language-Settings.ps1 to
Docs-Onboarding.ps1


Release process succeeds
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=4171903&view=logs&j=19b87903-f8bc-5cbb-22d9-4f6eb3469d8e&t=39d7f548-7a77-5d57-b2f3-bf0cc5f8dda2
... There is a failure in one of the other template package releases but
it's unrelated to this change.
@danieljurek danieljurek mentioned this issue Sep 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieljurek danieljurek

Labels
Docs
Projects
Azure SDK EngSys 📈
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs onboarding cleanup final: Rename ValidatePackageForOnboarding2 Azure/azure-sdk-tools
2 participants
@danieljurek @JimSuplizio