Fix broken relative paths in `matrix-generator` tests and samples + make the tests runnable by `common-tests/ci.yml`. #5095

konrad-jamrozik · 2023-01-09T22:08:22Z

This PR fixes paths I forgot to update when I did this PR:

Move supporting matrix generator assets out of eng/common #5027

And as such this PR contributes to addressing:

Update job-matrix samples and tests .NET SDKs to net6.0 and Ubuntu images to 22.04, and move them out of eng/common #4995

It also adds UnitTest tags to the matrix-generator tests so common-tests/ci.yml pipeline executes them.

Related work

Fix failing matrix-generator tests #5098

sima-zhu · 2023-01-09T22:31:13Z

To ensure we don't have any tests left behind, better to check the value of NotRun in log.

azure-sdk · 2023-01-09T22:48:15Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2023-01-09T23:05:59Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk · 2023-01-09T23:15:58Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

konrad-jamrozik · 2023-01-09T23:18:53Z

To ensure we don't have any tests left behind, better to check the value of NotRun in log.

Thanks for the tip!

We have:

NotRun                : {[ ] Should generate a sparse matrix where the entire base matrix is imported, [ ] Should 
                        import a matrix and combine with length=1 vectors, [ ] Should generate a matrix with 
                        nonSparseParameters and an imported sparse matrix, [ ] Should source imported display name 
                        lookups…}

but this is because I had to disable these tests, due to:

Fix failing matrix-generator tests #5098

azure-sdk · 2023-01-09T23:25:36Z

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

weshaggard · 2023-01-10T00:09:40Z

eng/common/scripts/job-matrix/job-matrix-functions.ps1

@@ -380,7 +380,7 @@ function ProcessImport([MatrixParameter[]]$matrix, [String]$selection, [Array]$n
    }

    if (!(Test-Path $importPath)) {
-        Write-Error "`$IMPORT path '$importPath' does not exist."
+        Write-Error "`$IMPORT path '$importPath' does not exist. Current dir: $(Get-Location)"


Is this debugging information something you plan to sync in eng/common or is it only temporary to help with getting these tests working?

ghost · 2023-01-10T03:15:59Z

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

fix paths

b199763

konrad-jamrozik added the Central-EngSys This issue is owned by the Engineering System team. label Jan 9, 2023

konrad-jamrozik requested review from weshaggard and sima-zhu January 9, 2023 22:08

konrad-jamrozik requested a review from a team as a code owner January 9, 2023 22:08

konrad-jamrozik self-assigned this Jan 9, 2023

add UnitTest tags

d01f239

sima-zhu approved these changes Jan 9, 2023

View reviewed changes

konrad-jamrozik changed the title ~~Fix broken relative paths in matrix-generator tests and samples.~~ Fix broken relative paths in matrix-generator tests and samples + make the tests runnable by common-tests/ci.yml. Jan 9, 2023

konrad-jamrozik requested a review from benbp as a code owner January 9, 2023 22:44

fix paths + add diagnostic output on failure

846e620

konrad-jamrozik force-pushed the users/kojamroz/fix_matrix_tests branch from 0e70f5c to 846e620 Compare January 9, 2023 22:58

konrad-jamrozik force-pushed the users/kojamroz/fix_matrix_tests branch 2 times, most recently from b325e67 to f2f92c0 Compare January 9, 2023 23:07

disable failing test

cc2d5e1

konrad-jamrozik force-pushed the users/kojamroz/fix_matrix_tests branch from f2f92c0 to cc2d5e1 Compare January 9, 2023 23:09

konrad-jamrozik mentioned this pull request Jan 9, 2023

Adding test pipeline for common-tests #5040

Merged

add link to issue tracking the disabled test.

95f918b

konrad-jamrozik mentioned this pull request Jan 9, 2023

Fix failing matrix-generator tests #5098

Open

weshaggard reviewed Jan 10, 2023

View reviewed changes

weshaggard approved these changes Jan 10, 2023

View reviewed changes

azure-sdk added the auto-merge label Jan 10, 2023

ghost merged commit 3418b9a into main Jan 10, 2023

ghost deleted the users/kojamroz/fix_matrix_tests branch January 10, 2023 03:17

konrad-jamrozik mentioned this pull request Feb 13, 2023

Move the test flag from get-codeowners.ps1 to the common PS1 test infra, common-tests #5434

Closed

konrad-jamrozik mentioned this pull request Apr 13, 2023

kojamroz contributions summary 11/21/2022 - 4/14/2023 #5974

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix broken relative paths in `matrix-generator` tests and samples + make the tests runnable by `common-tests/ci.yml`. #5095

Fix broken relative paths in `matrix-generator` tests and samples + make the tests runnable by `common-tests/ci.yml`. #5095

konrad-jamrozik commented Jan 9, 2023 •

edited

Loading

sima-zhu commented Jan 9, 2023

azure-sdk commented Jan 9, 2023

azure-sdk commented Jan 9, 2023

azure-sdk commented Jan 9, 2023

konrad-jamrozik commented Jan 9, 2023

azure-sdk commented Jan 9, 2023

weshaggard Jan 10, 2023

ghost commented Jan 10, 2023

Fix broken relative paths in matrix-generator tests and samples + make the tests runnable by common-tests/ci.yml. #5095

Fix broken relative paths in matrix-generator tests and samples + make the tests runnable by common-tests/ci.yml. #5095

Conversation

konrad-jamrozik commented Jan 9, 2023 • edited Loading

Related work

sima-zhu commented Jan 9, 2023

azure-sdk commented Jan 9, 2023

azure-sdk commented Jan 9, 2023

azure-sdk commented Jan 9, 2023

konrad-jamrozik commented Jan 9, 2023

azure-sdk commented Jan 9, 2023

weshaggard Jan 10, 2023

Choose a reason for hiding this comment

ghost commented Jan 10, 2023

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Fix broken relative paths in `matrix-generator` tests and samples + make the tests runnable by `common-tests/ci.yml`. #5095

Fix broken relative paths in `matrix-generator` tests and samples + make the tests runnable by `common-tests/ci.yml`. #5095

konrad-jamrozik commented Jan 9, 2023 •

edited

Loading

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.