Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I can use the Azure Go SDK to create a Azure Data Lake storage #329

Closed
7 tasks
jananivMS opened this issue Oct 10, 2019 · 2 comments
Closed
7 tasks
Assignees

Comments

@jananivMS
Copy link
Contributor

This user story covers the following:
Creation of a resource helper library using Azure Go SDK that can be used to deploy/delete/update the resource. This can be used in the operator code.

Acceptance Criteria
[Update this once the owner starts looking at the user story]

  • User can create a storage account enabled for Azure Data Lake given the spec

  • User can delete a storage account

  • User can create a Data Lake File System given a storage account

  • User can delete a Data Lake File System

  • Tests exist for the helper functions

  • The service principal information, subscription ID and tenant ID can be passed as environment variables to the helper library

  • The helper library has logging to diagnose issues

Epic reference*
#316

Tasks
Reference this issue when you create tasks for this user story

@clmccart
Copy link
Contributor

Currently blocked on this user story because ADLS Gen 2 requires a type of authorizer that does not exist in the go sdk. I will be focusing my efforts on newly created task #388 to address this blocker and move forward with this user story.

@clmccart
Copy link
Contributor

Closed by PR #390

Porges added a commit that referenced this issue May 11, 2021
Ok, this got a bit bigger than expected:

- Add `ValidatedType` which adds support for validations.
- Handle specially the `^.*/default$` validation used by Storage for names; disable AzureName when detected.
  - To do in future PR: make this more general.
- Add `SetAzureName` function instead of writing the “setter” code inline in the from-ARM conversion, which simplifies things somewhat.
- Simplify `PropertyDefinition` by removing general validation support; properties only have `Required` as a validation.
- Add a Defaulter webhook to copy `Name` into `AzureName` (when required), this has a marker comment for `controller-gen` which outputs the webhook configuration files.
- Set up webhooks for integration tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants