Go SDK Helper Functions for Datalake #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-service-operator into adls/gosdk_helpers
|
In this PR, there is a adlsgen2 resource manager which is very similar to the storage account resource manager except for that it enforces a few things that are required for a storage account to be a datalake (hierachical namespace enabled and storage type). I was operating under the assumption that it might make sense to have adls be it's own operator that is similar to storage account but it sounds like this may not make sense. Let me know if I should remove the adlsgen2 resourcemanager and just work off of storage. If so, it may also make sense to move the filesystem files under the storages directory. |
jananivMS
suggested changes
Oct 22, 2019
jananivMS
reviewed
Oct 24, 2019
|
|
||
| accountKey, err := getAccountKey(ctx, groupName, accountName, adlsClient) | ||
| if err != nil { | ||
| log.Fatalf("failed to get the account key for the authorizer: %v\n", err) |
There was a problem hiding this comment.
To be consistent with other files, I would use log.Error or log.Info instead of Fatalf
jananivMS
approved these changes
Oct 24, 2019
This was referenced Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR contains the azure go sdk helper functions for creating, getting, and deleting azure datalake enabled storage accounts as well as create, get, and delete for filesystems.
Additionally, this PR contains a shared access key authorizer to compensate for a gap in the azure autorest sdk. This authorizer was adapted from an open PR on the azure/go-autorest sdk.
closes #388
closes #329
Special notes for your reviewer:
I tried my best to isolate the autorest patch so that, once that PR gets merged in, it should be a pretty simple change to use the sdk instead of the files included in this PR. Would love feedback on the approach. The code cherry-picked from the outstanding PR on the autorest sdk is in pkg/resourcemanager/autorest
If applicable: