Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppInsights - Override function app properties in logs with Static Web Apps resource information #2635

Closed
anthonychu opened this issue Nov 10, 2020 · 2 comments · Fixed by #2679
Closed

AppInsights - Override function app properties in logs with Static Web Apps resource information #2635

anthonychu opened this issue Nov 10, 2020 · 2 comments · Fixed by #2679
Assignees
@kashimiz
Milestone
Functions Sprint 96

Comments

@anthonychu
Copy link
Member

anthonychu commented Nov 10, 2020 •
edited
Loading

2020/12/10 updating to only overriding cloud rolename. The remainder will be in #2654

Azure/static-web-apps#204

@annaji-msft can you share more details on what properties to override and where to get the value from?

@brettsam FYI
@ghost ghost assigned pragnagopa Nov 10, 2020
@anthonychu anthonychu changed the title AppInsights - Override function app properties with Static Web Apps resource information in logs AppInsights - Override function app properties in logs with Static Web Apps resource information Nov 10, 2020
@anthonychu anthonychu added this to the Triaged milestone Nov 24, 2020
@anthonychu anthonychu added the P1 label Nov 24, 2020
@anthonychu
Copy link
Member Author

Proposal

  • If WEBSITE_CLOUD_ROLENAME is set, use it to override Cloud RoleName in app insights
  • If WEBSITE_APPINSIGHTS_REQUEST_HOSTNAME is set, replace the request.URL hostname

https://github.com/anthonychu/20201201-appinsights-override/blob/872d98fecdfd2b9c238397d08be043931a799966/functions/MyRoleEnvironmentTelemetryInitializer.cs#L58-L73

@fabiocav fabiocav modified the milestones: Triaged, Functions Sprint 91 Dec 10, 2020
@anthonychu
Copy link
Member Author

Scoping this only to overriding the cloud rolename via WEBSITE_CLOUD_ROLENAME. The remainder of the work is split to #2654

@fabiocav fabiocav assigned kashimiz and unassigned brettsam Feb 3, 2021
@anthonychu anthonychu mentioned this issue Feb 8, 2021
Closed
kashimiz added a commit that referenced this issue Mar 2, 2021
@kashimiz
WEBSITE_CLOUD_ROLENAME value, if set, will override site name in Appl…
571a0d0 
…ication Insights. Resolves #2635
@kashimiz kashimiz mentioned this issue Mar 2, 2021
Merged
kashimiz added a commit that referenced this issue Mar 3, 2021
@kashimiz
WEBSITE_CLOUD_ROLENAME value, if set, will override site name in Appl…
99f2fc9 
…ication Insights. Resolves #2635
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kashimiz kashimiz

Labels
None yet
Projects
None yet
Milestone
Functions Sprint 96
Development

Successfully merging a pull request may close this issue.

WEBSITE_CLOUD_ROLENAME overrides site name in Application Insights Azure/azure-webjobs-sdk
5 participants
@brettsam @pragnagopa @fabiocav @anthonychu @kashimiz