Skip to content

Commit

Permalink
fix(bootstrap): kubernetes 1.28 support / remove outdated feature gat…
Browse files Browse the repository at this point in the history
…es (#31)
  • Loading branch information
tallaxes authored Nov 17, 2023
1 parent fdcd317 commit 5d6ed94
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 6 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
k8sVersion: ["1.25.x", "1.26.x", "1.27.x"]
k8sVersion: ["1.25.x", "1.26.x", "1.27.x", "1.28.x"]
env:
K8S_VERSION: ${{ matrix.k8sVersion }}
steps:
Expand All @@ -18,7 +18,9 @@ jobs:
with:
k8sVersion: ${{ matrix.k8sVersion }}
- run: K8S_VERSION=${{ matrix.k8sVersion }} make ci-test
# - uses: shogo82148/actions-goveralls@v1
# if: env.K8S_VERSION == '1.25.x'
# with:
# path-to-profile: coverage.out
- name: Send coverage
# should only send converage once https://docs.coveralls.io/parallel-builds
if: matrix.k8sVersion == '1.27.x'
env:
COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: goveralls -coverprofile=coverage.out -service=github
1 change: 1 addition & 0 deletions hack/toolchain.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ tools() {
# go install -tags extended github.com/gohugoio/[email protected]
go install golang.org/x/vuln/cmd/[email protected]
go install github.com/onsi/ginkgo/v2/ginkgo@latest
go install github.com/mattn/[email protected]

if ! echo "$PATH" | grep -q "${GOPATH:-undefined}/bin\|$HOME/go/bin"; then
echo "Go workspace's \"bin\" directory is not in PATH. Run 'export PATH=\"\$PATH:\${GOPATH:-\$HOME/go}/bin\"'."
Expand Down
1 change: 0 additions & 1 deletion pkg/providers/imagefamily/bootstrap/aksbootstrap.go
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ var (
"--enforce-node-allocatable": "pods",
"--event-qps": "0",
"--eviction-hard": "memory.available<750Mi,nodefs.available<10%,nodefs.inodesFree<5%",
"--feature-gates": "CSIMigrationAzureFile=true,DelegateFSGroupToCSIDriver=true,RotateKubeletServerCertificate=true",
"--image-gc-high-threshold": "85",
"--image-gc-low-threshold": "80",
"--keep-terminated-pod-volumes": "false",
Expand Down

0 comments on commit 5d6ed94

Please sign in to comment.