Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): kubernetes 1.28 support / remove outdated feature gates #31

Merged
merged 9 commits into from
Nov 17, 2023

Conversation

tallaxes
Copy link
Collaborator

@tallaxes tallaxes commented Nov 13, 2023

Description

Remove all feature gates passed to kubelet: CSIMigrationAzureFile, DelegateFSGroupToCSIDriver, RotateKubeletServerCertificate, fixing bootstrap on Kubernetes 1.28 nodes.

Adds 1.28 to test matrix (fixes #6), and test coverage reporting via coveralls.

Background:

DelegateFSGroupToCSIDriver feature flag is no longer supported in Kubernetes 1.28. More importantly, all of the currently set flags already default to true in all versions we care about:

Feature Default Stage Since Until
CSIMigrationAzureFile true Beta 1.24 1.25
CSIMigrationAzureFile true GA 1.26
DelegateFSGroupToCSIDriver true Beta 1.23 1.25
DelegateFSGroupToCSIDriver true GA 1.26 1.27
RotateKubeletServerCertificate true Beta 1.12

Reference:
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/
https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates-removed/

How was this change tested?

  • make presubmit, E2E tests, manually creating 1.28 cluster & scaling up

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


Copy link
Collaborator Author

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test

@tallaxes tallaxes marked this pull request as ready for review November 14, 2023 02:50
@tallaxes tallaxes mentioned this pull request Nov 14, 2023
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good, but a little confusing on the 1.27.x coverage, so looking for an answer there

.github/workflows/ci-test.yml Show resolved Hide resolved
@tallaxes tallaxes merged commit 5d6ed94 into main Nov 17, 2023
7 checks passed
@tallaxes tallaxes deleted the tallaxes/kubernetes-1.28 branch November 17, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI coverage for 1.28
3 participants