Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace x-ms-skip-url-encoding with allowReserved #1512

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Replace x-ms-skip-url-encoding with allowReserved #1512

merged 3 commits into from
Sep 11, 2024

Conversation

live1206
Copy link
Member

This is blocking a new RP kubernetesruntime generating SDK.

@microsoft-github-policy-service microsoft-github-policy-service bot added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Sep 11, 2024
@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 11, 2024 •
edited
Loading

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

x-ms-skip-url-encoding should be replaced with allowReserved

pshao25
pshao25 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@pshao25 pshao25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm just not sure if we should discourage the usage of x-ms-skip-url-encoding since we have already allowReserved.

@live1206
Copy link
Member Author

live1206 commented Sep 11, 2024 •
edited
Loading

LGTM. I'm just not sure if we should discourage the usage of x-ms-skip-url-encoding since we have already allowReserved.

I read somewhere before, we would like to remove all @extension from resource-manager tempaltes. With this PR, all have been removed in resource-manager now.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@live1206 live1206 added this pull request to the merge queue Sep 11, 2024
Merged via the queue into Azure:main with commit dfeee05 Sep 11, 2024
22 checks passed
@live1206 live1206 deleted the allow-reserved branch September 11, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurMa1978 ArthurMa1978 ArthurMa1978 approved these changes

@pshao25 pshao25 pshao25 approved these changes

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

Assignees
No one assigned
Labels
lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@live1206 @azure-sdk @ArthurMa1978 @pshao25