Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace x-ms-skip-url-encoding with allowReserved #1512

Merged
merged 3 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .chronus/changes/allow-reserved-2024-8-11-16-40-29.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
changeKind: feature
packages:
- "@azure-tools/typespec-azure-resource-manager"
---

`x-ms-skip-url-encoding` should be replaced with `allowReserved`
Original file line number Diff line number Diff line change
Expand Up @@ -537,10 +537,9 @@ model ManagementGroupNameParameter {
@added(Versions.v4)
model ScopeParameter {
/** The scope at which the operation is performed. */
@path
@path(#{ allowReserved: true })
@segment("scope")
@minLength(1)
@extension("x-ms-skip-url-encoding", true)
scope: string;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,8 @@ model ArmLocationResource<BaseType extends
*/
@doc("The default resourceUri parameter type.")
model ResourceUriParameter {
@path
@path(#{ allowReserved: true })
@doc("The fully qualified Azure Resource manager identifier of the resource.")
@extension("x-ms-skip-url-encoding", true)
@resourceParameterBaseFor([ResourceHome.Extension])
resourceUri: string;
}
Expand Down
Loading