[AutoPR @azure/arm-locks] Private links #4370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
26 tasks
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/13945/@azure_arm-locks
branch
2 times, most recently
from
623f4ba
to
a65c21b
Compare
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/13945/@azure_arm-locks
branch
from
a65c21b
to
49e1dee
Compare
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/13945/@azure_arm-locks
branch
from
49e1dee
to
a6a2e45
Compare
openapi-sdkautomation
bot
force-pushed
the
master
branch
from
38dd317
to
a6fbc39
Compare
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/13945/@azure_arm-locks
branch
8 times, most recently
from
6f35d2c
to
7d8c075
Compare
Co-authored-by: Chidozie Ononiwu <[email protected]>
* Always use x-ms-date for Hmac * Try to fix phone number tests * Still another error in phone number tests * Update phoneNumber session records * Update phone numbers node sessions * Manually fix node record sessions for phone numbers * Update missed session files Co-authored-by: JP Chen <[email protected]>
This PR makes three changes to our deployment template: - Add networkAcls to the Managed HSM properties - Remove the 60 second sleep after activation - Speed up challenge auth tests for KV Keys by using methods that don't require creating and deleting keys. The first is now needed, and without it deployment will fail. The second is no longer needed, since it looks like the az cli appropriately waits before coming back. Finally, the third is something I noticed - there's no reason to create and purge keys which takes a long time in order to test CAE.
## What - Bump @opentelemetry/api to 0.20.0 in @azure/core-tracing - Move all packages that are on core-http to the next core-tracing version - Remove version collision check from the tracer cache ## Why This is part of our effort to move everyone to OTel 0.20.0 - but we have to stage it due to a transitive dependency and a breaking change in OTel. This PR updates core-tracing to use the latest OTel, fixes any breaking changes, and moves packages that we can move to the latest version of core-tracing. Once core-rest-pipeline 1.1.0 is GA'd we'll be able to move the rest of the packages over to the latest core-tracing as well. Removing the version collision came out of an offline discussion after these changes were reviewed - since it's a common source of pain and hasn't added much benefit (tracer conflicts incompatibility was never a problem) we decided to remove that logic and always grab a unique symbol per OT compatibility. ## Callouts The packages that are already on core-v2 will _not_ be upgraded at this time - we'll coordinate that with the GA of core-rest-pipeline 1.1.0
…-persistence (Azure#15384) * [identity] Remove machine-code-dependent codepaths (Azure#15024) * [identityg Remove machine-code-dependent codepaths * Linter fixes * Disable broken perf test * Added missing import back * [identity] Add extension registration API and default credential stack * [identity-native] Introducing identity-native * [identity] Rework extension API. * Remove identity native * Identity-persistence module * Adding identity-vscode module * Updated rush configuration * Moved identity perf back to linking local identity * Symbolic refactor of extension system * Renamed MsalCredentialOptions to CacheableCredentialOptions * Use Symbol.for instead of hacking around SymbolConstructor * Improved identity-vscode samples * Use persistence by default if a persistence provider has been registered. * Improved identity-persistence samples * Rename to identity-cache-persistence * Feedback from arch board for mainline identity package * Rename CredentialPersistenceOptions, format and lint * Revert sanitization of scopes. * Regenerated API.md for mainline identity * Add tests and finalize @azure/identity-cache-persistence * Record tests for identity-cache-persistence * Renamed sample files. * Some changes for testing in identity * Updated identity-vscode * Remove async version of useIdentityExtension * Added a couple of tests for default no-extension behavior * Fixed tests in recorder * Removed errant console.log * Added basic tests of identity-vscode * Fixed a couple of tests that have started caching correctly * Added browser shim for extensions/consumer.ts * Mock keytar using sinon in live/playback environments * Disable persistence tests on node !== 12 * Addressed feedback in identity-cache-persistence * Restore perf-test * Removed sanitizeScopeUrl from recorder * Update sdk/identity/identity/src/credentials/visualStudioCodeCredential.ts Co-authored-by: Jeff Fisher <[email protected]> * Fix gitignores * Feedback for identity-vscode * Changelog entry for recorder changes. * core-http -> core-auth * setter methods instead of setter props * Some changes to docs and keywords * Fixed linter warning * Switch persistence tests from 12 to 14. * Make the tests even refuse to import msal-node-extensions on anything other than Node 14 * Reverted changes to recorder * master -> main * More master -> main * [identity] Make the samples extract only part of the token data Co-authored-by: Jeff Fisher <[email protected]>
…5850) * Adding support for temporary redirect * Lint
* Changes to create artifact in package directory
… fixing flaky tests to be more reliable. (Azure#15761) Making changes to simplify a flaky test (and hopefully make it more reliable). The main issue with the 'handle interrupted detach' method was that it relied on too many moving parts to work reliably. We could just eternally loop like we'd expect customers to do, but in the end we have a very simple test we're trying to perform - we want to receive, and while we're in the process of draining, cause a detach and have it early exit and reject/resolve immediately rather than waiting for the timeout. I reworked the test to make that simpler by just removing the unneeded connection.idle() and just calling directly into the onDetached method. Because it happens prior to rhea even seeing that we're draining we should reliably win that race each time. There were a couple of other things changed for this PR as well: - The max time per test was lowered accidentally. Bringing it back what's been used as the standard time in other libraries - Fixed a spot in receiveMessages() where, if the link had been closed, we'd falsly return an empty array instead of throwing an exception indicating the link closed. This didn't appear to be related to the bug but it's incorrect and can hide bugs so I'd rather just throw the error than eat the condition and return an empty array. It's rare, but when it does happen the empty array response isn't right either - we're probably in the middle of a connection reset/change event. Fixes Azure#13461
* Update links with master to use main * Update ci.yml files Co-authored-by: Chidozie Ononiwu <[email protected]>
* Update pipeline generation tool version Consume latest changes from pipeline generation tool in Azure/azure-sdk-tools#1708 * Update tool version to include fix for public ci Co-authored-by: Wes Haggard <[email protected]>
…ll anymore (Azure#15783) I’ve got some customers writing to me directly with some confusion regarding getToken returning null. We’ve got some remnants of this type, but at this point, Identity doesn’t return null (except for ClientSecretCredential in the browser, which is generally unusable outside of our tests). This PR is to update these docs and to give a bit of clarity on what errors we’re throwing.
Co-authored-by: Daniel Jurek <[email protected]>
* Ensure word alpha is present in dev build
* Add dev version to Save-Package-Properties.ps1 and includd in build process * Now with fewer pipelines * Add daily docs.ms work to docindex.yml * Update-DocsMsMetadata and required functions * Common * Docs meatadata release and daily docs build * eq * Loop over artifacts in paramaters.Artifacts * Add PackageInfo to path * download: current * Output artifacts * Pool * Use relative paths in package properties json file and use dev version as Version (if available) when setting metadata * Skip checking out docs repo if it's already checked out * Don't overcomplicate docs-metadata-release.yml * With parameters properly defined and redundant logic removed * Use TargetBranchName * Retain original version to differentiate where metadata and readme docs end up * Add docs repo support for GetDocsMetadata: first cut * Sparse checkout needs to include metadata * Add metadata from packages that aren't tracked in the CSV file yet * Use "dev" if the package has a "dev" version in JS. This will not work in other languages and shouldn't be put into eng/common. That will need to be refactored into logic that could be in Language-Settings.ps1 * Refactor and use sparse checkout everywhere * Refactor long path support * Correct path * Parameter names * Remove unnecessary parameter * Close quote * Add pipeline starting * Keep the single quotes * Output link to CI build * Refactor: * Rename docs-metadata-release2.yml" to "update-docsms-metadata.yml" * Documentation for Update-DocsMsMetadata.ps1 * Documentation for Update-DocsMsPackages.ps1 * Add function invocation to Update-DocsMsMetadata.ps1 to override the package metadata from PackageInfo before it's written into the metadata folder * Refactor logic for generating daily branch name * Add ability to override daily docs branch name at queue time * Apply suggestions from code review Co-authored-by: Wes Haggard <[email protected]> * Review feedback: Save-Package-Properties.ps1 * Update comments for path normalization * Change path normalization logic to not switch current location * Update docs * Add ability to specify variable name for default branch * Try convertToJson * Tab scope * Do doc artifact info loop in Update-DocsMsMetadata.ps1 instead of yaml template * Single quotes * Remove template loop * Remove extra template references * Move convertToJson * Try different formatting given convertToJson * Reverse Update-DocsMsMetadata.ps1 to operate on a single object. Looping can happen in yaml * Loop in yaml, Rename Update-DocsMsMetadata parameter * Try re-formatting yaml * Spell parameters properly * Missing backtick * Remove extra logging * First cut at default implementation * Move business logic inside Update-DocsMsMetadata.ps1, PowerShell can handle an array or a single item in the cmdlet parameters * Use proper function name * PackageProps has a DevVersion * No DefaultImplementation in this change. This should be part of a wider effort. * Straggling master -> main rename * Use existing devops starting logic * Remove extra condition * Fix backslashes * Correct number of backslashes * Use variable for branch name * Update eng/scripts/Language-Settings.ps1 Co-authored-by: Wes Haggard <[email protected]> * Review feedback * Do not replace the default branch with the tag in links when doing a Dev build (pointing to the default branch is preferable and the tag does not exist) * Conditions on docs version for template project * Do not run PublishDocsToNightlyBranch if TestPipeline is true * Performance improvements, switch to Linux to take advantage of paths that don't look like escape sequences to ConvertFrom-Json * Add markdown files to sparse checkout * Reproduce failure for template publishing * Remove eng, it's already there by default * Fix instances where metadata might not be available because of filtering Hide == true (e.g. in template packages). The only information consumed from CSV metadata at this time is the service name which gets normalized and placed in the package overview metadata. Co-authored-by: Wes Haggard <[email protected]>
* [Text Analytics] Update CHANGELOG with release date * edit
* Update change log headers based on guideline update Updates based on Azure/azure-sdk#3103 - Renamed "Key Bugs Fixed" to "Bugs Fixed" - Renamed "Fixed" to "Other Changes" Added a warning in validation if at lease one of the recommended headers aren't used. * Update eng/common/scripts/ChangeLog-Operations.ps1 Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: JoshLove-msft <[email protected]>
# Conflicts: # eng/pipelines/mgmt-ci.yml # eng/pipelines/mgmt-pr.yml
* arm-appconfiguration-release * arm-appconfiguration-release
Merge 9fb392c3cc6d332236ea007c20f1481428e62521 into 571282bb195d489c7a127d8a5336bda35a3b282e
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/13945/@azure_arm-locks
branch
from
f46b920
to
03ee84a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#13945
Installation Instructions
You can install the package
@azure/arm-locksof this PR using the following command:curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/13945/azure-sdk-for-js/@azure_arm-locks/azure-arm-locks-1.1.0.tgz" -o azure-arm-locks-1.1.0.tgz npm install azure-arm-locks-1.1.0.tgzDirect Download
The generated package can be directly downloaded from here: