[breaking] Use native Date.now()
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will conflict with #165. |
Ember doesn't support IE < 9 anymore.
|
Lgtm |
tricknotes
force-pushed
the
use-native-date-now
branch
from
3164299
to
4d7af36
Compare
|
Thanks! |
|
Will merge when ci completes |
rwjblue
added a commit
that referenced
this pull request
Feb 2, 2016
[breaking] Use native `Date.now()`
alias-mac
added a commit
to alias-mac/backburner.js
that referenced
this pull request
Sep 21, 2017
This allow us to use fake timers, such as `sinon.useFakeTimers`, to check the state of the app during the run loop. For example: if a popup is supposed to be triggered in X ms from now and it will show to the user during Y ms, then this will allow us to use fake timers to pause between X and Y and check the state of the Ember app at that exact time. This is related with BackburnerJS#263, BackburnerJS#179 and BackburnerJS#166. If someone needs to have the backburner clock separate from the global stubbed clock (as explained in BackburnerJS#179), then `_platform.now` config should be used to pass the native `Date.now` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember doesn't support IE < 9 anymore.