Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Update backburner.js #12930

Merged
merged 1 commit into from
Feb 10, 2016

Conversation

tricknotes
Copy link
Member

@tricknotes
Copy link
Member Author

It seems the test depending on window.setTimeout is failing.

Test failed: run.later: setTimeout should never run with a negative wait
    Failed assertion: stub setTimeout was used, expected: true, but was: undefined
    at http://localhost:13141/qunit/qunit.js:1462
    at http://localhost:13141/qunit/qunit.js:2145
    at http://localhost:13141/ember-tests.js:38124
    at http://localhost:13141/ember-tests.js:37907

https://travis-ci.org/emberjs/ember.js/jobs/107823949

I'll investigate it later.

@rwjblue
Copy link
Member

rwjblue commented Feb 8, 2016

My guess is that this is replacing window.setTimeout after Backburner has already grabbed its copy for _platform, we should update the test to mock the bb._platform prop instead of window.setTimeout.

/cc @runspired

@runspired
Copy link
Contributor

That would likely be the problem, I can take a look late late tonight or sometime tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants