[CLEARITEMS]: argument item taken out...tests still pass #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really a pull request, but might be. Having some troubles with my test run after upgrading to Ember 2.4.0.beta-3 which I suspect might be this commit emberjs/ember.js#12930.
In acceptance test land, running a simple
visitw/assert.equal(1,1)acts like I put a return pauseTest after the visit. Specifically get stuck somewhere here where my breakpoint is:I'm using a timemachine freeze in order to get a consistent date in my test run. Commenting this import out will allow my test run to go through. https://github.com/toranb/freeze-time-testing-example/blob/master/vendor/timemachine.js. Timemachine might be related to the second part of that commit (emberjs/ember.js#12930), but I first wanted to tackle the below question.
So, in this commit, was there meant to be an argument to
clearItems? Backburner tests still pass if I remove theitemargument. It looks like it is called here: https://github.com/snewcomer/backburner.js/blob/master/lib/backburner.js#L29