-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | August 2023 #669
Fix | August 2023 #669
Conversation
As promised in #599 I'd leave a message here about the new error I'm seeing with this branch. In summary what I think is happening is that the My simplified document structure is like this
When I have an existing This is also the case when I do And actually I get the same output with |
if isinstance(value, dict): | ||
internal_key = list(value.keys())[0] | ||
if internal_key.startswith("$"): | ||
return {expression_key: {"$not": value}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-right is the (omitted) else
part here even valid, e.g. {"$not": {"foo": 3}}
? All the examples I have seen with dict value are operator expressions, i.e. the condition here is always true. If that's the case this can be simplified. The added test doesn't cover this case so I can't tell for sure.
No description provided.