-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix | August 2023 #669
Merged
Merged
Fix | August 2023 #669
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d7b7701
fix: 576
roman-right 645b47e
fix: don't compare types
roman-right 329eada
fix: don't compare types
roman-right 7c2a879
fix: 591
roman-right b9abfc4
fix: 606, 600
roman-right 95184fb
fix: 629
roman-right cb10d9d
fix: 646
roman-right dc4d78b
fix: 648
roman-right 3c58c17
new type: BsonBinary
roman-right 68f406d
rollback: response model in the fastapi atest
roman-right b89f95d
fix: 664 validate on save before save
roman-right dc2c3fe
fix: 668 Support root models
roman-right e00f155
improvement: typing bug tag for GH actions
roman-right 90ca825
fix: alias for extra field
roman-right 1ed9832
fix: fix 676 - Pydantic warnings
roman-right 833a6c5
fix: fix 695 - validate_call wrapper
roman-right 45728a1
call wrapper test model
roman-right 356803e
test against pydantic 1.10 only
roman-right ca600bd
test against pydantic 1.10 only
roman-right f2ead1b
fix: pydantic 1.10.x
roman-right f76ca6c
roll-back: test matrix
roman-right 8a10b49
lower coverage limit
roman-right 5adce0b
pydantic 2.3 in the versions matrix
roman-right a774555
version: 1.22.0
roman-right File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-right is the (omitted)
else
part here even valid, e.g.{"$not": {"foo": 3}}
? All the examples I have seen with dict value are operator expressions, i.e. the condition here is always true. If that's the case this can be simplified. The added test doesn't cover this case so I can't tell for sure.