Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use third party as external dependencies #792

Closed

Conversation

uilianries
Copy link
Contributor

Greetings!

After the PR conan-io/conan-center-index#20010, I checked a little bit the current state of BehaviorTree, and there is a window to use external dependencies, instead of those vendorized versions. The only exception is for cppzmq, because it has an internal patch. But why moving to external dependencies, if vendorized is working and keeps versions aligned? Well, people will be able to use newer versions, or even use customized versions, without touching this project.

To summarize this PR:

  • Add the CMake option BTCPP_VENDOR_3RDPARTY. By default, it will be ON, and will follow the very same behavior as in master branch right now: Consumed all dependencies from 3rdparty folder. When using as OFF, it will use external instead, including:
    • foonathan-lexy/2022.12.1
    • zeromq/4.3.5
    • sqlite3/3.45.2
    • minicoro/0.1.3
    • minitrace/cci.20230905
    • wildcards/1.4.0
    • tinyxml2/10.0.0
    • gtest/1.14.0
    • cppzmq will be from 3rdparty folder always!

For now, I only checked it with Conan, but could be agnostic, by adding a find_package() in CMakeLists.txt and changing the target_link_libraries, but would requires more changes, harder to review, but could be a next PR.

@uilianries uilianries marked this pull request as draft March 22, 2024 12:54
@facontidavide
Copy link
Collaborator

thanks but everything fails in CI....

@uilianries
Copy link
Contributor Author

@facontidavide Sorry, still need some touch. I kept in draft to avoid merging, but I'll close for now to avoid triggering the CI and send notification, so I can test in my fork only. I'll re-open after fixing everything.

@uilianries uilianries closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants