behaviortree.cpp: add v4.5.0, improve maintainability, unvendor some dependencies

[valgur]

Also dropped v3.5.6.

• Resolves behaviortree.cpp: add versions 3.8.3,4.0.2,4.1.1 #16731
• Requires minitrace: add new version #20009

[ghost]

I detected other pull requests that are modifying behaviortree.cpp/all recipe:

• behaviortree.cpp: add versions 3.8.3,4.0.2,4.1.1 #16731

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

[Batodalaev]

Hello everyone, please can you tell me, when i can use this by conan-center?
I hope to be upgraded from 4.0.1 to 4.4.3.

Thank you in advance)

[valgur]

@facontidavide It looks like there might be a regression in v4.5.0. The build fails with a compilation error on GCC:

src/tree_node.cpp:49:55: error: implicit instantiation of undefined template 'std::array<std::function<BT::Any (BT::Ast::Environment &)>, 4>'
  std::array<ScriptFunction, size_t(PreCond::COUNT_)> pre_parsed;
                                                      ^
/usr/local/bin/../include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
src/tree_node.cpp:50:56: error: implicit instantiation of undefined template 'std::array<std::function<BT::Any (BT::Ast::Environment &)>, 4>'
  std::array<ScriptFunction, size_t(PostCond::COUNT_)> post_parsed;
                                                       ^
/usr/local/bin/../include/c++/v1/__tuple:219:64: note: template is declared here
template <class _Tp, size_t _Size> struct _LIBCPP_TEMPLATE_VIS array;
                                                               ^
2 errors generated.

and MSVC:

src\tree_node.cpp(49,55): error C2079: 'BT::TreeNode::PImpl::pre_parsed' uses undefined class 'std::array<BT::ScriptFunction,4>'
src\tree_node.cpp(50,56): error C2079: 'BT::TreeNode::PImpl::post_parsed' uses undefined class 'std::array<BT::ScriptFunction,4>'
src\tree_node.cpp(142,75): error C2109: subscript requires array or pointer type
src\tree_node.cpp(142,30): error C2530: 'parse_executor': references must be initialized
src\tree_node.cpp(143,21): error C3536: 'parse_executor': cannot be used before it is initialized
src\tree_node.cpp(146,5): error C2064: term does not evaluate to a function taking 1 arguments
src\tree_node.cpp(174,12): error C2440: 'return': cannot convert from 'int' to 'BT::TreeNode::PreScripts &'
src\tree_node.cpp(178,12): error C2440: 'return': cannot convert from 'int' to 'BT::TreeNode::PostScripts &'
src\tree_node.cpp(188,54): error C2109: subscript requires array or pointer type
src\tree_node.cpp(188,32): error C2530: 'parse_executor': references must be initialized
src\tree_node.cpp(189,24): error C3536: 'parse_executor': cannot be used before it is initialized
src\tree_node.cpp(201,11): error C2064: term does not evaluate to a function taking 1 arguments
src\tree_node.cpp(201,36): error C2062: type 'bool' unexpected
src\tree_node.cpp(202,7): error C2143: syntax error: missing ';' before '{'
src\tree_node.cpp(217,7): error C2181: illegal else without matching if
src\tree_node.cpp(225,12): error C2064: term does not evaluate to a function taking 1 arguments
src\tree_node.cpp(225,37): error C2062: type 'bool' unexpected
src\tree_node.cpp(226,7): error C2143: syntax error: missing ';' before '{'
src\tree_node.cpp(205,11): fatal  error C1903: unable to recover from previous error(s); stopping compilation

[facontidavide]

Sorry about that, I focus more on Linux than Windows, so this happened :(

As you may see here, it was fixed right after the release.
Let me generate 4.5.1 to address this

[facontidavide]

Decided to delete the old tag and create a new one, instead. So, the version number is still 4.5.0, but it now points to the current head of master 574a34f503eb80293cc3289b799811890fc1cc80

[valgur]

@facontidavide Thank you! That was quick. 😄

[uilianries]

Looking really good. I checked the upstream and this current change follows the version 4.x

[uilianries]

Is there an error which does not pass?

[valgur]

@uilianries Looks like it was not required after all. It built fine without it.

[conan-center-bot]

Conan v1 pipeline ✔️

All green in build 1 (6a0dbb4bdd2dd9740af664c56bc6488205dc61fc):

• behaviortree.cpp/3.7.0:
  All packages built successfully! (All logs)

• behaviortree.cpp/4.0.1:
  All packages built successfully! (All logs)

• behaviortree.cpp/3.8.6:
  All packages built successfully! (All logs)

• behaviortree.cpp/4.5.2:
  All packages built successfully! (All logs)

---

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (6a0dbb4bdd2dd9740af664c56bc6488205dc61fc):

• behaviortree.cpp/3.7.0:
  All packages built successfully! (All logs)

• behaviortree.cpp/4.5.2:
  All packages built successfully! (All logs)

• behaviortree.cpp/4.0.1:
  All packages built successfully! (All logs)

• behaviortree.cpp/3.8.6:
  All packages built successfully! (All logs)

[github-actions]

Hooks produced the following warnings for commit 6a0dbb4

behaviortree.cpp/3.7.0@#9deb30aba61244628ad694580af54155

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbehaviortree_cpp_v3.so' links to system library 'm' but it is not in cpp_info.system_libs.

behaviortree.cpp/3.8.6@#bbd68d2331cc27b25bec7816640ff3d4

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libbehaviortree_cpp_v3.so' links to system library 'm' but it is not in cpp_info.system_libs.

[uilianries]

Nice job! Thank you!