Add FUNCTION LIST command.
#277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
GumpacG,
aaron-congo,
jonathanl-bq,
acarbonetto,
tjzhang-BQ,
cyip10 and
yipin-chen
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
tjzhang-BQ
reviewed
May 17, 2024
tjzhang-BQ
reviewed
May 17, 2024
tjzhang-BQ
approved these changes
May 22, 2024
| * The command will be routed to all primary nodes. | ||
| * | ||
| * @since Redis 7.0 and above | ||
| * @see <a href="https://redis.io/docs/latest/commands/function-list/">redis.io</a> for details. |
There was a problem hiding this comment.
question: should we be linking redis or valkey right now? or does it not matter, i remember some change of replacing all redis to valkey that was talked about
There was a problem hiding this comment.
I don't care about links - will update all of them later in bulk.
java/client/src/main/java/glide/api/models/commands/function/FunctionListOptions.java
Outdated
Show resolved
Hide resolved
| } | ||
| } else { | ||
| assertEquals(expected, actual); | ||
| } |
There was a problem hiding this comment.
reminder to double-check the test results with the changes in the transaction IT pr to be safe?
| // TODO test with FCALL | ||
|
|
||
| // TODO FUNCTION FLUSH at the end |
There was a problem hiding this comment.
are these just reserving space for commands to be done later?
There was a problem hiding this comment.
Yes, I removed this TODO in the next PR
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
added a commit
that referenced
this pull request
Jun 5, 2024
* Add `FUNCTION LIST` command. (#277) Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]>
yipin-chen
pushed a commit
that referenced
this pull request
Jun 7, 2024
* Add `FUNCTION LIST` command. (#277) Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Add `FUNCTION LIST` command. (#277) Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Aaron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redis.io/docs/latest/commands/function-list/
Depends/based on #270
TODOs: