Removing p2pk support in wallet.py file #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed support for p2pk transaction wherever I found it in this file
|
if it is considered not in use the feature can be deleted and needs cleaning. |
|
Sir I am asking will this be rewarded as per bug bounty of 500 usdt?
…On Tue, 20 Jul, 2021, 8:49 pm berbagi12, ***@***.***> wrote:
if it is considered not in use the feature can be deleted and needs
cleaning.
Something that has no function can be deleted.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUULJTN2CVV4CFRBNUL7L43TYWHX7ANCNFSM5AVIVNHA>
.
|
maybe sir, just waiting for the admin to get rewards or not? |
|
Fine, sorry I will wait for admin to check on my pr
…On Tue, 20 Jul, 2021, 8:53 pm berbagi12, ***@***.***> wrote:
Sir I am asking will this be rewarded as per bug bounty of 500 usdt?
… <#m_-1200224020606277431_>
On Tue, 20 Jul, 2021, 8:49 pm berbagi12, *@*.***> wrote: if it is
considered not in use the feature can be deleted and needs cleaning.
Something that has no function can be deleted. — You are receiving this
because you authored the thread. Reply to this email directly, view it on
GitHub <#44 (comment)
<#44 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUULJTN2CVV4CFRBNUL7L43TYWHX7ANCNFSM5AVIVNHA
.
maybe sir, just waiting for the admin to get rewards or not?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#44 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUULJTP3HM3O2UJLJDRX323TYWIGBANCNFSM5AVIVNHA>
.
|
janus
pushed a commit
that referenced
this pull request
Nov 11, 2021
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues 135254331e Import fixes for sanitizer reported issues d5fb86940e refactor: use c++11 range based for loop in checkObject ff9c379304 refactor: Use nullptr (c++11) instead of NULL 08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support 66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus 808d487292 ci: travis -> cirrus c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration 4a5b0a1c65 build: Move source entries out to sources.mk 6c7d94b33c build: cleanup wonky gen usage a222637c6d Merge #23: Merge changes from jgarzik/univalue@1ae6a23 f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD 1ae6a231a0 Merge pull request #57 from MarcoFalke/test_fix 92bdd11f0b univalue_write: remove unneeded sstream.h include ffb621c130 Merge pull request #56 from drodil/remove_sstream_header f33acf9fe8 Merge commit '7890db9~' into HEAD 66e0adec4d Remove unnecessary sstream header from univalue.h 88967f6586 Version 1.0.4 1dc113dbef Merge pull request #50 from luke-jr/pushKV_bool 72392fb227 [tests] test pushKV for boolean values c23132bcf4 Pushing boolean value to univalue correctly 81faab26a1 Merge pull request #48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS b17634ef24 Update URLs to MIT license. 88ab64f6b5 Merge pull request #46 from jasonbcox/master 35ed96da31 Merge pull request #44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit 420c226290 Merge pull request #45 from MarcoFalke/Mf1710-univalue-revert-test git-subtree-dir: src/univalue git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed support for p2pk transaction wherever I found it in this file
Description
To start the epic revolution of removing non-segwit transactions.
Notes
I deleted code for p2pk and replaced sign with pass to remove the ability to sign for p2pk.
BTC/BGL PR reward address
0x6957d999Bbea7771C22beA4Dea4d7c0E39E8Aa1F