Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port multiple master-targeted fixes to janus release branch #56

Closed

Conversation

slowriot
Copy link
Contributor

@slowriot slowriot commented Sep 1, 2021

Description

This merges the following PRs originally intended for master branch, to janus/release-0.1.7 branch:

Please see commit messages in this PR for specifics of each change. Rationale and detailed description of each changeset can be found in the PRs above.

The merge here was built entirely using cherry-pick commits, which will minimise requirements for rebasing - the above PRs can also be merged to master, in addition to this PR merging to janus/release-0.1.7, without generating future merge conflicts.

BTC/BGL PR reward address

ETH/USDT: 0x50b92AB67A3D3DE8c3506D9287893D9a52655486 - please note bounties should be paid either for the above PRs individually, or this one proportionately - otherwise there would be duplication of payment for the same changes.

…tcoin core, and turn off warning silencing for implicit fallthrough
# Conflicts:
#	src/test/data/base58_encode_decode.json
…f calls, and add placeholder warning to suggest possible final types
…to be used, and re-enable unused parameter warning to identify unintentionally unused parameters in future
@slowriot slowriot changed the title Port multiple master-targeted fixes to janus release branch WIP: Port multiple master-targeted fixes to janus release branch Sep 1, 2021
…ScriptPubKeyMan to accomodate new fuzzing classes
@slowriot slowriot changed the title WIP: Port multiple master-targeted fixes to janus release branch Port multiple master-targeted fixes to janus release branch Sep 1, 2021
@slowriot
Copy link
Contributor Author

slowriot commented Sep 1, 2021

Current state of tests at this point:
image

@janus
Copy link
Collaborator

janus commented Sep 1, 2021

script_tests should pass now. I didn't push the commit.
util_tests passed on my system. I would dig out what I have not pushed.

test/util_tests.cpp(2285): Leaving test case "remove_prefix"; testing time: 21250us
test/util_tests.cpp(48): Leaving test suite "util_tests"; testing time: 10571738us
Leaving test module "BGL Core Test Suite"; testing time: 10572123us

*** No errors detected

@slowriot slowriot mentioned this pull request Sep 6, 2021
janus pushed a commit that referenced this pull request Nov 11, 2021
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues
135254331e Import fixes for sanitizer reported issues
d5fb86940e refactor: use c++11 range based for loop in checkObject
ff9c379304 refactor: Use nullptr (c++11) instead of NULL
08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support
66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus
808d487292 ci: travis -> cirrus
c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration
4a5b0a1c65 build: Move source entries out to sources.mk
6c7d94b33c build: cleanup wonky gen usage
a222637c6d Merge #23: Merge changes from jgarzik/univalue@1ae6a23
f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD
1ae6a231a0 Merge pull request #57 from MarcoFalke/test_fix
92bdd11f0b univalue_write: remove unneeded sstream.h include
ffb621c130 Merge pull request #56 from drodil/remove_sstream_header
f33acf9fe8 Merge commit '7890db9~' into HEAD
66e0adec4d Remove unnecessary sstream header from univalue.h
88967f6586 Version 1.0.4
1dc113dbef Merge pull request #50 from luke-jr/pushKV_bool
72392fb227 [tests] test pushKV for boolean values
c23132bcf4 Pushing boolean value to univalue correctly
81faab26a1 Merge pull request #48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS
b17634ef24 Update URLs to MIT license.
88ab64f6b5 Merge pull request #46 from jasonbcox/master
35ed96da31 Merge pull request #44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit
420c226290 Merge pull request #45 from MarcoFalke/Mf1710-univalue-revert-test

git-subtree-dir: src/univalue
git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
@madnadyka madnadyka closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants