Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from electron:main #3

Open
wants to merge 3,061 commits into
base: main
Choose a base branch
from
Open

[pull] main from electron:main #3

wants to merge 3,061 commits into from

Conversation

pull[bot]
Copy link

@pull pull bot commented Aug 25, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@commit-lint
Copy link

commit-lint bot commented Aug 25, 2021

Features

Continuous Integration

Code Refactoring

Chore

Tests

Bug Fixes

Documentation

Contributors

codebytere, dsanders11, ckerr, aiddya, tr2-harada, miniak, zcbenz, brhenrique, erickzhao, wanted002, jkleinsc

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@mergify
Copy link

mergify bot commented Apr 15, 2022

@pull-request-quantifier[bot] is not allowed to run commands

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

2 similar comments

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137834 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80898 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13186 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

8 similar comments

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137861 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80925 -56936
Percentile : 100%

Total files changed: 2249

Change summary by file extension:
.gitignore : +10 -4
.yml : +3505 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

11 similar comments

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 137868 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Large
Size       : +80932 -56936
Percentile : 100%

Total files changed: 2250

Change summary by file extension:
.gitignore : +10 -4
.yml : +3512 -2860
.js : +2889 -5054
.json : +1688 -466
.lock : +0 -0
.sh : +20 -8
.clang-tidy : +4 -0
.md : +10372 -5319
.git-blame-ignore-revs : +5 -0
.gitattributes : +20 -4
.nvmrc : +1 -1
.gn : +626 -402
.gni : +1333 -411
.py : +415 -446
.json5 : +5 -1
.tmpl : +60 -0
.h : +6098 -4371
.cc : +15909 -11979
.ts : +20742 -14930
.html : +1478 -1401
.css : +2 -0
.svg : +0 -97
.grd : +0 -6
.grdp : +0 -123
.patches : +113 -64
.patch : +13213 -6720
.bat : +15 -25
.ps1 : +0 -8
.manifest : +43 -26
.mm : +2089 -1797
.plist : +26 -1
.rc : +0 -59
.sigs : +10 -0
.fragment : +2 -0
.mojom : +25 -13
.idl : +92 -2
.eslintrc : +0 -30
.cpp : +9 -6
.txt : +1 -274
.mjs : +48 -0
.gyp : +32 -0
.github/CODEOWNERS : +3 -2
DEPS : +20 -23
ELECTRON_VERSION : +0 -1
script/git-export-patches : +1 -1
script/git-import-patches : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

ckerr and others added 30 commits September 12, 2024 10:56
chore: delegate handle creation in NativeImage::Resize()

chore: delegate handle creation in NativeImage::Crop()

chore: delegate handle creation in NativeImage::CreateEmpty()
* feat: hide menu bar on windows fullscreen

* test: state prior to html fullscreen transition

* refactor: restore `#ifdef` for readability

Reference: #43402 (comment)

* docs: menu bar behavior changed

---------

Co-authored-by: John Kleinschmidt <[email protected]>
)

* refactor: update BadgeManagerFactory

* refactor: update NetworkContextServiceFactory

* refactor: update ElectronExtensionSystemFactory

* refactor: update UsbChooserContextFactory

* refactor: update UsbHidChooserContextFactory

* refactor: update SerialChooserContextFactory

* refactor: update FileSystemAccessPermissionContextFactory
#43657)

fix: prevent spinning cursor when launching utility process on Windows
* chore: move Archaeologist to GHA

* chore: test archaelogist changes

* Revert "chore: test archaelogist changes"

This reverts commit a575d6e.

* chore: properly name steps in archaeologist-dig
* refactor: add EmitWarning(Isolate*, ...) warning

* chore: remove EmitWarning(node::Environment*, ...)

* chore: add code comments

* fixup! refactor: add EmitWarning(Isolate*, ...) warning

* chore: remove unused node #includes
* refactor: move scope scaffolding into SettletScope

idea stolen from SpellCheckScope

* refactor: move impl of PromiseBase::RejectPromise() to the cc file

* chore: remove unused #include
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.6 to 3.26.7.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@4dd1613...8214744)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Closes #43714.

Fixes an issue where the resizing border was not being handled correctly on Linux WCO
caption buttons. This is now taken into account as a part of the NonClientHitTest.
…r's scope (#43729)

fix: Emit() should not leak converted arg handles into caller's HandleScope
…updates (#43681)

Bumps the npm_and_yarn group with 1 update in the / directory: [express](https://github.com/expressjs/express).
Bumps the npm_and_yarn group with 1 update in the /spec directory: [send](https://github.com/pillarjs/send).


Updates `express` from 4.19.2 to 4.20.0
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](expressjs/express@4.19.2...4.20.0)

Updates `body-parser` from 1.20.2 to 1.20.3
- [Release notes](https://github.com/expressjs/body-parser/releases)
- [Changelog](https://github.com/expressjs/body-parser/blob/master/HISTORY.md)
- [Commits](expressjs/body-parser@1.20.2...1.20.3)

Updates `path-to-regexp` from 0.1.7 to 0.1.10
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v0.1.7...v0.1.10)

Updates `serve-static` from 1.15.0 to 1.16.0
- [Release notes](https://github.com/expressjs/serve-static/releases)
- [Changelog](https://github.com/expressjs/serve-static/blob/master/HISTORY.md)
- [Commits](expressjs/serve-static@v1.15.0...1.16.0)

Updates `send` from 0.16.2 to 0.19.0
- [Release notes](https://github.com/pillarjs/send/releases)
- [Changelog](https://github.com/pillarjs/send/blob/master/HISTORY.md)
- [Commits](pillarjs/send@0.16.2...0.19.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:development
  dependency-group: npm_and_yarn
- dependency-name: body-parser
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: path-to-regexp
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: serve-static
  dependency-type: indirect
  dependency-group: npm_and_yarn
- dependency-name: send
  dependency-type: direct:development
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: John Kleinschmidt <[email protected]>
* chore: iwyu mojom.h headers

* fixup! chore: iwyu mojom.h headers

make previously-indirect include dependency direct

* fixup! fixup! chore: iwyu mojom.h headers

make previously-indirect include dependency direct
* chore: bump chromium in DEPS to 130.0.6673.0

* chore: bump chromium in DEPS to 130.0.6675.0

* chore: bump chromium in DEPS to 130.0.6677.2

* chore: bump chromium in DEPS to 130.0.6679.0

* 5802981: [Partitioned Popins] UKM

https://chromium-review.googlesource.com/c/chromium/src/+/5802981

* 5799275: ash: Create //chrome/browser/ui/ash/web_view

https://chromium-review.googlesource.com/c/chromium/src/+/5799275

* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url

https://chromium-review.googlesource.com/c/chromium/src/+/5791853

* 5805208: Move third_party/jacoco to a cipd/ subdirectory.

https://chromium-review.googlesource.com/c/chromium/src/+/5805208

* chore: fixup patch indices

* 5771091: Introduce InputManager class for handling input in Viz.

https://chromium-review.googlesource.com/c/chromium/src/+/5771091

* 5498921: [Permission] Remove SubscribeToPermissionStatusChange from PermissionManager

https://chromium-review.googlesource.com/c/chromium/src/+/5498921

* 5791853: [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents for loading url

https://chromium-review.googlesource.com/c/chromium/src/+/5791853

* 5801311: Don't use int for bindings

https://chromium-review.googlesource.com/c/chromium/src/+/5801311

* 5548827: [Web Install] Define the web-app-installation PermissionPolicy

https://chromium-review.googlesource.com/c/chromium/src/+/5548827

* 5786325: Add Infrastructure for Hand tracking permission

https://chromium-review.googlesource.com/c/chromium/src/+/5786325

* chore: fixup patch indices

* chore: bump chromium in DEPS to 130.0.6681.0

* [Views AX] Move BrowserAccessibility* to //ui/accessibility/platform

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5520052

* chore: e patches all

* Don't have default arguments on virtual functions in render_frame_host.h

https://chromium-review.googlesource.com/c/chromium/src/+/5809399

* test: log if loadURL fails in base url test

* chore: bump chromium in DEPS to 130.0.6683.2

* chore: fix support_mixed_sandbox_with_zygote.patch

content: restore old DisableJit behavior

https://chromium-review.googlesource.com/c/chromium/src/+/5804255

* chore: update patch indices

* chore: bump chromium in DEPS to 130.0.6685.0

* Parallel process launching

Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5015584

* chore: update feat_expose_documentloader_setdefersloading_on_webdocumentloader.patch

No manual changes; patch applied with fuzz 1

* chore: e patches all

* chore: bump chromium in DEPS to 130.0.6687.0

* chore: bump chromium in DEPS to 130.0.6689.0

* chore: bump chromium in DEPS to 130.0.6691.0

* chore: bump chromium in DEPS to 130.0.6693.0

* chore: update patches

* chore: bump chromium in DEPS to 130.0.6695.0

* chore: free up macos disk space as soon as possible

* 5824143: Use checked in source lists for third_party/boringssl

https://chromium-review.googlesource.com/c/chromium/src/+/5824143

* chore: update patches

* 5824122: Extensions: Add a new view type enum for developer tools contexts

https://chromium-review.googlesource.com/c/chromium/src/+/5824122

* 5806109: Option for JavaScriptExecuteRequestForTests() to ignore content settings

https://chromium-review.googlesource.com/c/chromium/src/+/5806109

* build: free up disk space on gn check too

* 5799369: [Refactoring] Make allow_http1_for_streaming_upload flags false.

https://chromium-review.googlesource.com/c/chromium/src/+/5799369

* fixup! 5015584: Parallel process launching | https://chromium-review.googlesource.com/c/chromium/src/+/5015584

* Disable failing test for short-term

See: #43730

* oops

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <[email protected]>
Co-authored-by: Charles Kerr <[email protected]>
Co-authored-by: Keeley Hammond <[email protected]>
Co-authored-by: John Kleinschmidt <[email protected]>
Co-authored-by: clavin <[email protected]>
Co-authored-by: electron-appveyor-updater[bot] <161660339+electron-appveyor-updater[bot]@users.noreply.github.com>
* refactor: CallMethodWithArgs() now takes a span of value handles

* perf: use std::array instead of std::vector to hold Emit arg parameter packs

* chore: remove unused gin_helper::EmitEvent(iso, obj, name, span<Local>)
perf: hold V8FunctionInvoker args in a std::array
…npm_and_yarn group across 1 directory (#43753)

build(deps): bump path-to-regexp

Bumps the npm_and_yarn group with 1 update in the /spec directory: [path-to-regexp](https://github.com/pillarjs/path-to-regexp).


Updates `path-to-regexp` from 1.8.0 to 1.9.0
- [Release notes](https://github.com/pillarjs/path-to-regexp/releases)
- [Changelog](https://github.com/pillarjs/path-to-regexp/blob/master/History.md)
- [Commits](pillarjs/path-to-regexp@v1.8.0...v1.9.0)

---
updated-dependencies:
- dependency-name: path-to-regexp
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…med 'highlight'. (#43773)

chore: fix ambiguous error of multiple methods named 'highlight'
Because we used decrementing negative source ids for fake video id when
instantating a native macOS screen share picker, we eventually hit the
`DesktopMediaID::kFakeId = -3` in Chromium source code which displayed a
test green screen.

In this change we reserve our own fake id of `-4` and decrement the
window id integer for uniqueness instead.

Co-authored-by: Fedor Indutny <[email protected]>
* fix: -Wunsafe-buffer-usage warnings in Clipboard::WriteBuffer()

* chore: add a DCHECK to confirm the BigBuffer is full
* fix: createWindow shouldn't load URL for webContents

* chore: add non about blank test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.