-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Loading component and use it in SearchInput #464
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: ba439aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📦 Next.js Bundle Analysis for @blobscan/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #464 +/- ##
==========================================
+ Coverage 89.84% 89.85% +0.01%
==========================================
Files 146 145 -1
Lines 9621 9622 +1
Branches 1019 1022 +3
==========================================
+ Hits 8644 8646 +2
+ Misses 977 976 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!.
Left a comment.
Can we also display a "No results found" message in the search results modal when no results are returned? Currently, the loading spinner appears and disappears too quickly, which might confuse users as there is no indication whether results were found.
…und. Also now we show the loading spinner while debouncing
I improved this after the last commit. Now, we show the loading spinner while debouncing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One last thing: let's add a changeset
Checklist
Description
A
Loading
component is added to provide a loading animation while fetching search results in theSearchInput
component. This improves the user experience by indicating that the search is in progress.Related Issue
#289
Screenshots: