Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Loading component and use it in SearchInput #464

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

luis-herasme
Copy link
Member

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

A Loading component is added to provide a loading animation while fetching search results in the SearchInput component. This improves the user experience by indicating that the search is in progress.

Related Issue

#289

Screenshots:

image

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 1:36pm
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 1:36pm
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 1:36pm
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 1:36pm
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 1:36pm
blobscan-staging ⬜️ Ignored (Inspect) Visit Preview Aug 2, 2024 1:36pm

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: ba439aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 31, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (deb72ed) to head (ba439aa).
Report is 6 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #464      +/-   ##
==========================================
+ Coverage   89.84%   89.85%   +0.01%     
==========================================
  Files         146      145       -1     
  Lines        9621     9622       +1     
  Branches     1019     1022       +3     
==========================================
+ Hits         8644     8646       +2     
+ Misses        977      976       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!.

Left a comment.

Can we also display a "No results found" message in the search results modal when no results are returned? Currently, the loading spinner appears and disappears too quickly, which might confuse users as there is no indication whether results were found.

apps/web/src/components/Loading.tsx Outdated Show resolved Hide resolved
@luis-herasme
Copy link
Member Author

Currently, the loading spinner appears and disappears too quickly,

I improved this after the last commit. Now, we show the loading spinner while debouncing.

@luis-herasme
Copy link
Member Author

No results found component:
image

Copy link
Member

@PJColombo PJColombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One last thing: let's add a changeset

@luis-herasme luis-herasme merged commit dbe414b into next Aug 2, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
@PabloCastellano PabloCastellano deleted the search-loading-spinner branch August 2, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants