Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiko/cql 1.7.2 port #172

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Kiko/cql 1.7.2 port #172

merged 2 commits into from
Jan 24, 2023

Conversation

Kiko-Aumond
Copy link

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Kiko-Aumond Kiko-Aumond requested a review from a team as a code owner January 24, 2023 06:07
@Kiko-Aumond Kiko-Aumond requested review from RuofanKong and removed request for a team January 24, 2023 06:07
@dmlyubim dmlyubim merged commit e2f9e7f into dmlyubim/cql-1.7.2-port Jan 24, 2023
Kiko-Aumond added a commit that referenced this pull request Feb 4, 2023
* syncing to 1.7.2

* common public rllib cql renames

* patching sac dist class get

* retrofitting rllib/offline package to 1.7.2

* retrofit space_utils 1.7.2

* retrofit ray.tune.registry to 1.7.2 (add input registry)

* test changes

* cql test pendulum data

* in 1.3, replay buffer isn't reworked to track capacity vs. current size

* Updating metrics to 1.7.2 (update sampled count on request to enable proper train iteration size)

* slight test refactoring to enable intermediate debugging

* fixing bazel test //rllib:test_cql

* additional cql_sac cleanup

* removing cql apex sac tests

* rolling back non-existent policy call signature in offline component

* trying to fix macos python verison at 3.8.15

* changing bazel definition for test_cql.
The test passes for me in command line but fails in the pipeline where it
fails to locate the json data file.

* parity with BUILD for test_cql in 1.7.2 (removing data glob) -- does it help?

* fixes -- this now runs with the benchmark

* Rolling back cql_dqn cleanup

* trying to add data label to test

* set recursive mod 777 on /home/vsts/work/_temp/_bazel_vsts directory prior to build

* use $TEST_TMPDIR env variable instead of literal directory name

* Kiko/cql 1.7.2 port (#172)

* set recursive mod 777 on /home/vsts/work/_temp/_bazel_vsts directory prior to build

* use $TEST_TMPDIR env variable instead of literal directory name

* brining more changes from 1.13.0 to update timesteps_total metric correctly for CQL

* REVERTING TO PYTHON 3.8 FOR MAC

* explicitly set MACOSX_DEPLOYMENT_TARGET env variable

* removed minor version of Python; renamed steps to relect correct Python version

* get latest pip version to test MacOs wheels

* updated hash

* undid changes to info,yml

* unbounded setuptools

* undid change

* Fix MacOs version if bdist_wheel generates incorrect MacOS version tag for wheel

* undid changes

* undid changes

* undid changes

* force reinstall tune and upstream requirements

* updatd CI hash

* updated dependencies

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated ci folder hash

* updated requirements

* updated requirements

* updates CI hash

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* undid requirement changes

* updated ci folder hash

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated dependencies

* updated requirements

* updated dependencies

* apt update

* fixed GCC download, set Ubuntu 20.04 as default OS for pipeline

* updated requirements

* updated requirements

* fixed setup.py

* updated ci hash

* fixed setup.py

* fixed setup.py

* fixed setup.py

* updated requirements

* fixed setup.py

* force reintall of torch and torchvision

* updated ci hash

* fixed rllib requirements

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated requirements

* updated dependencies

* updated dependencies

* updated requirements

* updated requirements

* updated requirements

* explicitly set locale in MacOS to fix test_signal

* keep only Ray Fork Build fixes

---------

Co-authored-by: Dmitriy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants