Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kiko/fix build #175

Merged
merged 94 commits into from
Feb 4, 2023
Merged

Kiko/fix build #175

merged 94 commits into from
Feb 4, 2023

Conversation

Kiko-Aumond
Copy link

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

dmlyubim and others added 30 commits January 10, 2023 10:47
@dmlyubim
syncing to 1.7.2
5db8b9a
@dmlyubim
common public rllib cql renames
55bc018
@dmlyubim
patching sac dist class get
31b77f5
@dmlyubim
retrofitting rllib/offline package to 1.7.2
844dba4
@dmlyubim
retrofit space_utils 1.7.2
ace3f85
@dmlyubim
retrofit ray.tune.registry to 1.7.2 (add input registry)
6640af3
@dmlyubim
test changes
a9b7a56
@dmlyubim
cql test pendulum data
e09c33d
@dmlyubim
in 1.3, replay buffer isn't reworked to track capacity vs. current size
313f88a
@dmlyubim
Updating metrics to 1.7.2 (update sampled count on request to enable …
1e5159a 
…proper train iteration size)
@dmlyubim
slight test refactoring to enable intermediate debugging
5f12afa
@dmlyubim
fixing bazel test //rllib:test_cql
8598a97
@dmlyubim
additional cql_sac cleanup
0c20a1b
@dmlyubim
removing cql apex sac tests
2dbfb9d
@dmlyubim
rolling back non-existent policy call signature in offline component
016bde6
@dmlyubim
trying to fix macos python verison at 3.8.15
e099a1d
@dmlyubim
changing bazel definition for test_cql.
625bf4b 
The test passes for me in command line but fails in the pipeline where it
fails to locate the json data file.
@dmlyubim
parity with BUILD for test_cql in 1.7.2 (removing data glob) -- does …
d5abccb 
…it help?
@dmlyubim
fixes -- this now runs with the benchmark
d56abda
@dmlyubim
Rolling back cql_dqn cleanup
fb7ef1a
@dmlyubim
trying to add data label to test
90660d0
@Kiko-Aumond
set recursive mod 777 on /home/vsts/work/_temp/_bazel_vsts directory …
057eebf 
…prior to build
@Kiko-Aumond
use $TEST_TMPDIR env variable instead of literal directory name
aa2eae4
@Kiko-Aumond
Kiko/cql 1.7.2 port (#172)
e2f9e7f 
* set recursive mod 777 on /home/vsts/work/_temp/_bazel_vsts directory prior to build

* use $TEST_TMPDIR env variable instead of literal directory name
@dmlyubim
brining more changes from 1.13.0 to update timesteps_total metric cor…
f809b8f 
…rectly for CQL
@dmlyubim
Merge branch 'dmlyubim/cql-1.7.2-port' of github.com:BonsaiAI/ray int…
65ddbce 
…o dmlyubim/cql-1.7.2-port
@dmlyubim
REVERTING TO PYTHON 3.8 FOR MAC
bf7c81d
@Kiko-Aumond
explicitly set MACOSX_DEPLOYMENT_TARGET env variable
1f8c889
@Kiko-Aumond
Merge remote-tracking branch 'origin/dmlyubim/cql-1.7.2-port' into ki…
3008348 
…ko/cql-1.7.2-port
@Kiko-Aumond
removed minor version of Python; renamed steps to relect correct Pyth…
fcadf4b 
…on version
@Kiko-Aumond Kiko-Aumond requested review from a team as code owners February 3, 2023 20:29
@Kiko-Aumond Kiko-Aumond requested review from akanso, RuofanKong and a team and removed request for a team February 3, 2023 20:29
RuofanKong
RuofanKong approved these changes Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@RuofanKong RuofanKong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! LGTM!

@Kiko-Aumond Kiko-Aumond merged commit e5047fa into releases/1.3.0 Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RuofanKong RuofanKong RuofanKong approved these changes

@akanso akanso Awaiting requested review from akanso akanso is a code owner automatically assigned from BonsaiAI/ray-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kiko-Aumond @RuofanKong @dmlyubim