Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page load flickering #312

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: page load flickering #312

merged 1 commit into from
Sep 19, 2024

Conversation

gabitoesmiapodo
Copy link
Collaborator

@gabitoesmiapodo gabitoesmiapodo commented Sep 18, 2024

Closes #311

Description:

  • Fixes the issue with the flickering / blank contents section when the page is done loading. We can evaluate if or when to use the .lazy.tsx file naming feature on a per-project basis. I don't think we need it in this particular case, anyways.
  • Despite the fix working on this repo, the issue still remains in the landing page (even if I apply this exact fix), but after some research I detected the issue comes from something inside the TokenInput component or its demo. I'll try to fix it there, or delegate the task to someone else.

Steps:

Load and re-load the page several times, every part of it should load instantaneously without delay (maybe you'll still see some displacement because of the custom font loading delay, though).

Type of change:

  • New feature
  • Bug fix
  • Breaking change
  • Enhancement
  • Refactoring
  • Chore

How Has This Been Tested?

  • Manual testing
  • Automated tests
  • Other (explain)

Remember to check that:

  • Your code follows the style guidelines of this project
  • You have performed a self-review of your code
  • You have commented your code in hard-to-understand areas
  • You have made corresponding changes to the documentation
  • Your changes generate no new warnings

Screenshots

Sep-18-2024.16-46-20.mp4

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dappbooster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 7:47pm
docs.dappbooster ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 7:47pm

Copy link
Member

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

@gabitoesmiapodo gabitoesmiapodo merged commit 2487fd9 into develop Sep 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading issue
2 participants