Interactor modeling workflow #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ejiawustl
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a draft of how analysis on a single TF would look in the interactor_workflow.
The output needs adjustment based on the analysis you have done.
This should be enough to finish up this process. Once the functions seem to be doing what we need them to, they need to be moved into source code. That is when there also needs to be tests.
Make sure you read the tests that chatgpt produces -- make sure to use the fixtures i provided -- and that they make sense to use. Remove any that are superfluous. We are both providing a way to set breakpoints now, and also giving ourselves time to make sure there are no obvious bugs.
note at the top, in the first function, where max_lrb has been added