Migration to k4geo #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrieucF
reviewed
Nov 21, 2023
|
Can you also add the two files equivalent to these one: https://github.com/BrieucF/LAr_scripts/tree/main#getting-lar_scripts-package-and-the-required-data-files and update the README ? |
|
I added the small file in data/ and the big files in Eos and updated the README |
| @@ -139,5 +139,5 @@ dmypy.json | |||
|
|
|||
| # my stuff | |||
| *.sub | |||
| *.root | |||
|
|
|||
There was a problem hiding this comment.
I removed the *.root line because it's duplicate (there is the same line at the top of the file)
|
Hi @BrieucF - just to be sure, you are satisfied by these changes and the PR is ready to be merged once key4hep/k4geo#304 and HEP-FCC/k4RecCalorimeter#59 are merged? Thanks, Giovanni |
|
Hi Giovanni, yes! And I'll do a final check once the other PR are merged. |
|
Thanks Giovanni! |
giovannimarchiori
deleted the
gmarchio-main-20231103-k4geomigration-FCCDetPR63
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes related to k4geo migration of theta-module segmentation