migrate theta-module readout and related code to k4geo #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! |
kjvbrt
reviewed
Dec 11, 2023
kjvbrt
reviewed
Dec 11, 2023
…rieve them only if specified by user - i.e. not needed for ECAL-only clustering
|
Juraj had started to get rid of the position tools from topo clustering (assuming the cells have positioned attached to them): #57 . Shall we do it here or adapt PR#57 after merging this PR? |
|
key4hep/k4geo#304 has been merged, we should merge this as well, I propose to deal with the cell position tools suppression in another PR |
|
I agree :) |
|
Thanks! And yes it's great to get rid of the positioning tools at clustering level since we can cluster cells that already have positions attached to them |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes related to k4geo migration of FCC segmentation classes and related utilities - this PR is basically a rebasing to the latest version of main of #56