Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initial tray icon scaling #468

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Fix initial tray icon scaling #468

merged 3 commits into from
Oct 8, 2023

Conversation

serebit
Copy link
Member

@serebit serebit commented Oct 8, 2023

Description

Resolves #467.

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

JoshStrobl
JoshStrobl requested changes Oct 8, 2023
View reviewed changes
src/panel/applets/tray/TrayApplet.vala Outdated Show resolved Hide resolved
JoshStrobl
JoshStrobl approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@JoshStrobl JoshStrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

EbonJaeger
EbonJaeger requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style thing, otherwise LGTM!

src/panel/applets/tray/TrayApplet.vala Outdated Show resolved Hide resolved
EbonJaeger
EbonJaeger approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@serebit serebit merged commit bc90025 into main Oct 8, 2023
1 check passed
@serebit serebit deleted the initial-tray-icon-scaling branch October 8, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshStrobl JoshStrobl JoshStrobl approved these changes

@EbonJaeger EbonJaeger EbonJaeger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] System Tray icon scaling option doesn't work on initial startup
3 participants
@serebit @JoshStrobl @EbonJaeger