Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backpress not working properly in simulator of video,dictation and flash templates #314

Closed
tejavojjala opened this issue Dec 20, 2016 · 8 comments
Assignees

Comments

@tejavojjala
Copy link
Contributor

Problems in Video and Dictation templates:

Create a project and run the simulator. Now select a video(or dictation). Click back press. You will be redirected to choose. Instead go to the last fragment and click restart. Now click back press. Instead of redirecting to choose you will be exited.

Problems in flash card template:

Clicking backpress should take you to the previous card. Instead the app is exiting.

@opticod shall I create a pr for this?

tejavojjala pushed a commit to tejavojjala/BuildmLearn-Toolkit-Android that referenced this issue Dec 26, 2016
tejavojjala pushed a commit to tejavojjala/BuildmLearn-Toolkit-Android that referenced this issue Dec 26, 2016
@opticod
Copy link
Collaborator

opticod commented Dec 31, 2016

Case Video and Dictation templates: Once the user restarts,on clicking back press, it should not redirect to last fragment. Hence it looks fine to me.

But with flash card template, its an issue, while checking one card, on pressing back, it should redirect to last fragment for that card.

You can continue with fixing the 2nd one.

@tejavojjala
Copy link
Contributor Author

@opticod after restart,on clicking back press i didn't mean last fragment, l am saying the very first fragment where the user is asked to choose from the list available.
Like say there are 2 different passages in a dictation project. Now if you choose the 1st and instead of submitting do backpress(not back button), you will again be redirected to first fragment and asked to choose one of the dictations. Now again choose 1st,submit it and restart. Now if you perform back press the app is exited instead of asking you to choose one of the dictations.

@opticod
Copy link
Collaborator

opticod commented Jan 13, 2017

@iit2014086 , yea my mistake. I checked it. Its not showing the very first fragment.

tejavojjala pushed a commit to tejavojjala/BuildmLearn-Toolkit-Android that referenced this issue Jan 14, 2017
tejavojjala pushed a commit to tejavojjala/BuildmLearn-Toolkit-Android that referenced this issue Jan 14, 2017
tejavojjala pushed a commit to tejavojjala/BuildmLearn-Toolkit-Android that referenced this issue Jan 14, 2017
@opticod
Copy link
Collaborator

opticod commented Jan 14, 2017

@iit2014086, this issue is only with simulator or also with the created APKs?

@tejavojjala
Copy link
Contributor Author

@opticod the issue is with the created APK's also. Shall I send a pr to toolkit-mobile-templates too?

@opticod
Copy link
Collaborator

opticod commented Jan 14, 2017

Yaa. First u create a PR there, and wait for it to get reviewed and merged. Then with those changes and updated master branch of Toolkit-mobile-templates, create those updated APKs and add it to PR targeted here.

@tejavojjala
Copy link
Contributor Author

Okay. I will send a pr there ;)

tejavojjala pushed a commit to tejavojjala/BuildmLearn-Toolkit-Android that referenced this issue Feb 10, 2017
updated apks in assets from dev branch of toolkit-mobile-templates
opticod added a commit that referenced this issue Feb 13, 2017
@opticod
Copy link
Collaborator

opticod commented Feb 13, 2017

Closed via #394

@opticod opticod closed this as completed Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants