-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix backpress issue(#314) raised in Toolkit-Android #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iit2014086 , your implementation in videocollection template goes to a infinite loop when: do restart, press next, then home, and now press back for infinite times. Try to clear the stack at suitable situations.
077ee75
to
247b0d1
Compare
@opticod seems like the issue is same with Dictation App for the same flow. Update the pr making changes in Dictation and VideoCollection files. Check it now :) |
@iit2014086, did you well checked your implementation? Let me know, we will review and merge it. |
@opticode Yes, I did. |
@iit2014086, why on clicking video item 3 and then pressing backpress redirects the user to content of video item 2? It should only redirect it to home ? no need of changing the natural flow. |
@opticod okay I first thought of pressing back should work like pressing "Previous button". Then in flash cards template, If user clicks on 1st card, now after that suppose he chooses 5th from navigation drawer, then on clicking back should user go to 1st card or 4th card? |
It will go to 1st card. The back key will move the user to "back state". Also, restart button, cleans some instances from stack. |
@opticod When a user goes to the last activity(choose a dictation -> Enter Text -> Click Submit) what should happen on clicking back. Currently it goes back to DetailActivity(with text entered). Shouldn't the application close?(Becoz why go back after submitting he should either restart or exit). |
6a74d29
to
104a3e6
Compare
@iit2014086 , for self correction, he can go back to previous submit fragment. (default flow) |
@iit2014086, So what is your current implementation? |
104a3e6
to
2b28189
Compare
@opticod In FlashCards: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tejavojjala.
@tejavojjala , I have merged to dev branch according to recent contribution policy. You can check your merged commit here : https://github.com/BuildmLearn/Toolkit-mobile-templates/commits/dev |
Made the required changes as discussed in BuildmLearn/BuildmLearn-Toolkit-Android#314