Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix backpress issue(#314) raised in Toolkit-Android #45

Closed

Conversation

tejavojjala
Copy link
Contributor

Made the required changes as discussed in BuildmLearn/BuildmLearn-Toolkit-Android#314

Copy link
Collaborator

@opticod opticod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iit2014086 , your implementation in videocollection template goes to a infinite loop when: do restart, press next, then home, and now press back for infinite times. Try to clear the stack at suitable situations.

@tejavojjala
Copy link
Contributor Author

@opticod seems like the issue is same with Dictation App for the same flow. Update the pr making changes in Dictation and VideoCollection files. Check it now :)

@opticod
Copy link
Collaborator

opticod commented Jan 19, 2017

@iit2014086, did you well checked your implementation? Let me know, we will review and merge it.

@tejavojjala
Copy link
Contributor Author

@opticode Yes, I did.

@opticod
Copy link
Collaborator

opticod commented Jan 20, 2017

@iit2014086, why on clicking video item 3 and then pressing backpress redirects the user to content of video item 2? It should only redirect it to home ? no need of changing the natural flow.

@tejavojjala
Copy link
Contributor Author

@opticod okay I first thought of pressing back should work like pressing "Previous button". Then in flash cards template, If user clicks on 1st card, now after that suppose he chooses 5th from navigation drawer, then on clicking back should user go to 1st card or 4th card?

@opticod
Copy link
Collaborator

opticod commented Jan 21, 2017

It will go to 1st card. The back key will move the user to "back state". Also, restart button, cleans some instances from stack.

@tejavojjala
Copy link
Contributor Author

@opticod When a user goes to the last activity(choose a dictation -> Enter Text -> Click Submit) what should happen on clicking back. Currently it goes back to DetailActivity(with text entered). Shouldn't the application close?(Becoz why go back after submitting he should either restart or exit).

@tejavojjala tejavojjala force-pushed the backpressIssueFix branch 2 times, most recently from 6a74d29 to 104a3e6 Compare January 23, 2017 07:53
@opticod
Copy link
Collaborator

opticod commented Jan 23, 2017

@iit2014086 , for self correction, he can go back to previous submit fragment. (default flow)

@opticod
Copy link
Collaborator

opticod commented Jan 24, 2017

@iit2014086, So what is your current implementation?

@tejavojjala
Copy link
Contributor Author

@opticod
In Dictation and Video:
Whenever user presses Restart a new stack of activities is created into which first we push home activity and then detail activity. This way when user presses back he will reach home activity instead of exiting the app.

In FlashCards:
Instead of finishing the activity whenever user presses next. I am just leaving it in the stack.

Copy link
Collaborator

@opticod opticod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tejavojjala.

@opticod
Copy link
Collaborator

opticod commented Feb 10, 2017

@tejavojjala , I have merged to dev branch according to recent contribution policy. You can check your merged commit here : https://github.com/BuildmLearn/Toolkit-mobile-templates/commits/dev

@opticod opticod closed this Feb 10, 2017
@tejavojjala tejavojjala deleted the backpressIssueFix branch February 10, 2017 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants