Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard Coding the strings from activity to matchTemplate. #280

Closed
wants to merge 1 commit into from
Closed

Hard Coding the strings from activity to matchTemplate. #280

wants to merge 1 commit into from

Conversation

octacode
Copy link
Contributor

@octacode octacode commented Dec 12, 2016 •
edited
Loading

#279
I have removed the hard coded the strings from activity folder to match_template folder.
Thanks

opticod
opticod requested changes Jan 4, 2017
View reviewed changes
Copy link
Collaborator

@opticod opticod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octacode, Thanks for the PR.
Please resolve the merge conflicts and follow Snake case naming convention for string ids

@octacode
Copy link
Contributor Author

octacode commented Jan 4, 2017

Great, I will make the changes

@octacode
Copy link
Contributor Author

@opticod
Thanks for your approval, I have implemented your suggestions and have opened a new PR #399 for the same. Please have a look at it.

@octacode octacode closed this Jan 17, 2017
@octacode octacode deleted the HardcodedStrings branch January 17, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opticod opticod opticod requested changes

Assignees
No one assigned
Labels
request changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octacode @opticod