-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving all hardcoded strings to strings.xml #279
Comments
I would like to work on it. |
If still need help, I will be happy to help. |
I can help too. |
@opticod I think there are too many lint issues also. We can add those too if you feel so. |
@octacode @codingblazer @rijuldhir , Cool, then lets distribute these works among us all. Guys let me know, if anyone wants any modification. |
Awesome @opticod. ^^ |
@opticod. We only need to hard code those strings which we have to display as a message to the user. Right? |
If still there is any unassigned issue, let me know I will be happy to work on that. |
@octacode Yes, and rest wherever possible but not all declare them as constant globally. |
@vishwesh3 Cool, Can you replace all hardcoded dimes into dimen.xml ? |
Guys when replacing them please minimise the redundancy of newly added strings or dimen, by this what i mean is ...if there already an existing entry of it then better use that rather than adding one more entry in xml file. And make noun as non translatable. |
Yes. |
I realised that, most of you are creating minute mistakes while making PRs but they can be critical in production, so will not merge any big change before DEC-2016 release. |
Is the issue closed? Can I help in any way |
@sm86, this issues is already assigned. |
You should be moving all the existing necessary hardcoded strings to strings.xml.
Anyone want to help me out here?
The text was updated successfully, but these errors were encountered: