Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving all hardcoded strings to strings.xml #279

Open
opticod opened this issue Dec 12, 2016 · 15 comments
Open

Moving all hardcoded strings to strings.xml #279

opticod opened this issue Dec 12, 2016 · 15 comments

Comments

@opticod
Copy link
Collaborator

opticod commented Dec 12, 2016

You should be moving all the existing necessary hardcoded strings to strings.xml.
Anyone want to help me out here?

@octacode
Copy link
Contributor

octacode commented Dec 12, 2016

I would like to work on it.

@codingblazer
Copy link
Contributor

If still need help, I will be happy to help.

@rijuldhir
Copy link

I can help too.

@codingblazer
Copy link
Contributor

@opticod I think there are too many lint issues also. We can add those too if you feel so.

@opticod
Copy link
Collaborator Author

opticod commented Dec 12, 2016

@octacode @codingblazer @rijuldhir , Cool, then lets distribute these works among us all.
@octacode Can you fix all hard coded strings in first 10 folders(alphabetically sorted order)? viz. activity to matchtemplate folder.
@rijuldhir Can you fix all hard coded strings in last 7 folders(alphabetically sorted order)? viz. model to views folder. + ToolkitApplication + all files in res folder if any.
@codingblazer Can you fix lint issues except the "HARDCODED String" issue ?

Guys let me know, if anyone wants any modification.

@octacode
Copy link
Contributor

Awesome @opticod. ^^

@octacode
Copy link
Contributor

@opticod. We only need to hard code those strings which we have to display as a message to the user. Right?

@jainkuniya
Copy link
Contributor

If still there is any unassigned issue, let me know I will be happy to work on that.

@opticod
Copy link
Collaborator Author

opticod commented Dec 12, 2016

@octacode Yes, and rest wherever possible but not all declare them as constant globally.

@opticod
Copy link
Collaborator Author

opticod commented Dec 12, 2016

@vishwesh3 Cool, Can you replace all hardcoded dimes into dimen.xml ?

@opticod
Copy link
Collaborator Author

opticod commented Dec 12, 2016

Guys when replacing them please minimise the redundancy of newly added strings or dimen, by this what i mean is ...if there already an existing entry of it then better use that rather than adding one more entry in xml file.

And make noun as non translatable.

@jainkuniya
Copy link
Contributor

Yes.

@opticod
Copy link
Collaborator Author

opticod commented Dec 13, 2016

I realised that, most of you are creating minute mistakes while making PRs but they can be critical in production, so will not merge any big change before DEC-2016 release.

@sm86
Copy link

sm86 commented Dec 22, 2016

Is the issue closed? Can I help in any way

@opticod
Copy link
Collaborator Author

opticod commented Dec 22, 2016

@sm86, this issues is already assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants