Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded all dimen to dimen.xml #288

Closed
wants to merge 0 commits into from
Closed

Hardcoded all dimen to dimen.xml #288

wants to merge 0 commits into from

Conversation

jainkuniya
Copy link
Contributor

part of issue #279

opticod
opticod previously requested changes Dec 13, 2016
View reviewed changes
Copy link
Collaborator

@opticod opticod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is failing.
Check log at https://travis-ci.org/BuildmLearn/BuildmLearn-Toolkit-Android/builds/183547923

@jainkuniya
Copy link
Contributor Author

@opticod Travis check passed.
There is some code in fragment_home.xml which is commented under (line no:- 56-104).
Hidden until BuildmLearn store app is published to play store
Should I uncomment this?

@opticod
Copy link
Collaborator

opticod commented Dec 13, 2016

Not required for now.

@opticod opticod dismissed their stale review December 13, 2016 13:34

Travis passed

@jainkuniya
Copy link
Contributor Author

Ok

@jainkuniya jainkuniya closed this Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opticod opticod opticod left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jainkuniya @opticod