Add a rustls-webpki harness #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
cpu
reviewed
Nov 27, 2023
Comment on lines
+121
to
+124
| // Very dumb: rustls-webpki doesn't allow compressed IPv6 string representations, | ||
| // so we need to round-trip through `std::net::IpAddr`. This in turn requires | ||
| // us to round-trip through `webpki::IpAddr` and perform a leak, since | ||
| // we have no outliving reference to borrow against. |
There was a problem hiding this comment.
FWIW, as of rustls/webpki 0.102.0-alpha.7 the compressed repr should work. We'll probably have a final release with that code in the next couple of weeks.
There was a problem hiding this comment.
Awesome, thank you! We'll keep this harness up-to-date with each version as it goes out of alpha 🙂
(Also for the record, the "very dumb" is referring to me leaking to hack around the lifetimes here, not your APIs.)
There was a problem hiding this comment.
Also for the record, the "very dumb" is referring to me leaking to hack around the lifetimes here, not your APIs
Haha yeah, that's the context I read it in too but I appreciate the clarification :-D
|
Thank you, this is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a little bored on a flight and added this.
Still needs to be hooked up to the CI/CD.Done.CC @cpu -- you might/should be able to reuse bits of this for your own in-tree runner 🙂
Closes #88.