Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis yml to build for Linux and MacOS #479

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Update travis yml to build for Linux and MacOS #479

merged 2 commits into from
Oct 15, 2020

Conversation

seanlowjk
Copy link
Contributor

Summary

Completes the last task in #434

Description

Adds checks for builds for both Mac OS and Linux

@anubh-v
Copy link
Contributor

anubh-v commented Oct 10, 2020

It looks like the build step adds significant time to the Mac OS jobs on Travis.
@JunWei96 do we have a monthly limit on the Travis usage?

@JunWei96
Copy link
Contributor

There are no limits on the usage of Travis CI for public repositories. So I think it should be fine.

If there are any urgent PR, we can always force merge it into master branch an have the CI do its job later.

@JunWei96
Copy link
Contributor

@seanlowjk, should the command be npm run electron:linux and npm run electron:mac instead?

@seanlowjk
Copy link
Contributor Author

Eyup! @JunWei96 I'll fix that

Copy link
Contributor

@JunWei96 JunWei96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JunWei96 JunWei96 merged commit ac1cb3d into CATcher-org:master Oct 15, 2020
anubh-v added a commit to anubh-v/CATcher that referenced this pull request Dec 17, 2020
* Add IsCategorical Tests

* Add automated build for Linux and MacOS (CATcher-org#479)

* Add Conflict Model Tests (CATcher-org#487)

* Update usage instructions for Windows (CATcher-org#488)

* Prevent unwanted caching by adding headers to API calls (CATcher-org#482)

* Relax template correctness rule (CATcher-org#484)

* Create logging (CATcher-org#481)

* Update package.json

* Direct import logger into main electron process (CATcher-org#489)

* Update usage-notes.md

* Update usage-notes.md

* Update usage-notes.md

* Fix Regex Checker and Tests

* Fix for Copy Pasting of MacOS  (CATcher-org#496)

Edit Control Key Directives to include Mac

* Fix Alt Tabbing Bug  (CATcher-org#497)

* Version Bump

* Refactor Label Model

* Adding Unit Test for Description Component (CATcher-org#480)

* Adding Tests for Instance Methods for Issue Model (CATcher-org#495)

Add Tests to the following methods: clone(), numOfUnresolvedDisputes(), createGithubTesterResponse(), createGithubTutorResponse(), createGithubTeamResponse(), createGithubIssueDescription()

* Fix Pasting of images (CATcher-org#505)

Used browser based paste event

* CATcher version bump

* Migrate CI to Github Actions from Appveyor and Travis  (CATcher-org#509)

- Migrate CI to Github Actions
- Remove dependency on csv-parse

* Update README.md

* Fix Tests Names and Tests Grouping

* Make Labelling Adjectives Clearer

* Fix Typos

Co-authored-by: Low Jun Kai, Sean <[email protected]>
Co-authored-by: Low Jun Kai, Sean <[email protected]>
Co-authored-by: Koh Jun Wei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants